Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752643AbcLES0v (ORCPT ); Mon, 5 Dec 2016 13:26:51 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:47494 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752592AbcLES0r (ORCPT ); Mon, 5 Dec 2016 13:26:47 -0500 Date: Mon, 05 Dec 2016 13:26:45 -0500 (EST) Message-Id: <20161205.132645.1122516124371851668.davem@davemloft.net> To: bianpan2016@163.com Cc: michael.chan@broadcom.com, prashant.sreedharan@broadcom.com, sbaddipa@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] netdev: broadcom: propagate error code From: David Miller In-Reply-To: <1480758977-4234-1-git-send-email-bianpan2016@163.com> References: <1480758977-4234-1-git-send-email-bianpan2016@163.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 05 Dec 2016 09:27:25 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 397 Lines: 12 From: Pan Bian Date: Sat, 3 Dec 2016 17:56:17 +0800 > Function bnxt_hwrm_stat_ctx_alloc() always returns 0, even if the call > to _hwrm_send_message() fails. It may be better to propagate the errors > to the caller of bnxt_hwrm_stat_ctx_alloc(). > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188661 > > Signed-off-by: Pan Bian Applied.