Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752885AbcLES2F (ORCPT ); Mon, 5 Dec 2016 13:28:05 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:47532 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752848AbcLES14 (ORCPT ); Mon, 5 Dec 2016 13:27:56 -0500 Date: Mon, 05 Dec 2016 13:27:54 -0500 (EST) Message-Id: <20161205.132754.1207366793139836952.davem@davemloft.net> To: bianpan2016@163.com Cc: stephen@networkplumber.org, bridge@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] net: bridge: set error code on failure From: David Miller In-Reply-To: <1480764803-5577-1-git-send-email-bianpan2016@163.com> References: <1480764803-5577-1-git-send-email-bianpan2016@163.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 05 Dec 2016 09:28:33 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 396 Lines: 12 From: Pan Bian Date: Sat, 3 Dec 2016 19:33:23 +0800 > Function br_sysfs_addbr() does not set error code when the call > kobject_create_and_add() returns a NULL pointer. It may be better to > return "-ENOMEM" when kobject_create_and_add() fails. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188781 > > Signed-off-by: Pan Bian Applied.