Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752658AbcLESfO (ORCPT ); Mon, 5 Dec 2016 13:35:14 -0500 Received: from mail-wm0-f42.google.com ([74.125.82.42]:38196 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752165AbcLESeh (ORCPT ); Mon, 5 Dec 2016 13:34:37 -0500 Subject: Re: [PATCH V2 net 05/20] net/ena: fix RSS default hash configuration To: Matt Wilson References: <1480857578-5065-1-git-send-email-netanel@annapurnalabs.com> <1480857578-5065-6-git-send-email-netanel@annapurnalabs.com> <20161205042028.GF4310@u54ee753d2d1854bda401.ant.amazon.com> Cc: linux-kernel@vger.kernel.org, davem@davemloft.net, netdev@vger.kernel.org, dwmw@amazon.com, zorik@annapurnalabs.com, alex@annapurnalabs.com, saeed@annapurnalabs.com, msw@amazon.com, aliguori@amazon.com, nafea@annapurnalabs.com From: Netanel Belgazal Message-ID: Date: Mon, 5 Dec 2016 20:32:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161205042028.GF4310@u54ee753d2d1854bda401.ant.amazon.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1276 Lines: 35 On 12/05/2016 06:20 AM, Matt Wilson wrote: > On Sun, Dec 04, 2016 at 03:19:23PM +0200, Netanel Belgazal wrote: >> ENA default hash configure IPv4_frag hash twice instead of > configure -> configures. You may want to include "erroneously". What > is the consequence of this bug? I'll fix and I'll add explain the effect of this bug. > >> configure non ip packets. > configuring non-IP packets. OK. > > --msw > >> Signed-off-by: Netanel Belgazal >> --- >> drivers/net/ethernet/amazon/ena/ena_com.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/amazon/ena/ena_com.c b/drivers/net/ethernet/amazon/ena/ena_com.c >> index 3066d9c..46aad3a 100644 >> --- a/drivers/net/ethernet/amazon/ena/ena_com.c >> +++ b/drivers/net/ethernet/amazon/ena/ena_com.c >> @@ -2184,7 +2184,7 @@ int ena_com_set_default_hash_ctrl(struct ena_com_dev *ena_dev) >> hash_ctrl->selected_fields[ENA_ADMIN_RSS_IP4_FRAG].fields = >> ENA_ADMIN_RSS_L3_SA | ENA_ADMIN_RSS_L3_DA; >> >> - hash_ctrl->selected_fields[ENA_ADMIN_RSS_IP4_FRAG].fields = >> + hash_ctrl->selected_fields[ENA_ADMIN_RSS_NOT_IP].fields = >> ENA_ADMIN_RSS_L2_DA | ENA_ADMIN_RSS_L2_SA; >> >> for (i = 0; i < ENA_ADMIN_RSS_PROTO_NUM; i++) {