Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751827AbcLESrU (ORCPT ); Mon, 5 Dec 2016 13:47:20 -0500 Received: from lelnx193.ext.ti.com ([198.47.27.77]:41784 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751320AbcLESrS (ORCPT ); Mon, 5 Dec 2016 13:47:18 -0500 Subject: Re: [PATCH] net: ethernet: ti: cpdma: use desc_read in chan_process instead of raw read To: Ivan Khoronzhuk , References: <1480730715-16000-1-git-send-email-ivan.khoronzhuk@linaro.org> CC: , , From: Grygorii Strashko Message-ID: Date: Mon, 5 Dec 2016 12:47:16 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1480730715-16000-1-git-send-email-ivan.khoronzhuk@linaro.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [128.247.83.173] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 988 Lines: 37 On 12/02/2016 08:05 PM, Ivan Khoronzhuk wrote: > There is desc_read() macros to read desc fields, so no need to > use __raw_readl(); > > Signed-off-by: Ivan Khoronzhuk I'm going to update it all at once as part of [1]. [1] https://lkml.org/lkml/2016/12/1/781 > --- > Based on net-next/master > > drivers/net/ethernet/ti/davinci_cpdma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/ti/davinci_cpdma.c b/drivers/net/ethernet/ti/davinci_cpdma.c > index c776e45..d96dca5 100644 > --- a/drivers/net/ethernet/ti/davinci_cpdma.c > +++ b/drivers/net/ethernet/ti/davinci_cpdma.c > @@ -1132,7 +1132,7 @@ static int __cpdma_chan_process(struct cpdma_chan *chan) > } > desc_dma = desc_phys(pool, desc); > > - status = __raw_readl(&desc->hw_mode); > + status = desc_read(desc, hw_mode); > outlen = status & 0x7ff; > if (status & CPDMA_DESC_OWNER) { > chan->stats.busy_dequeue++; > -- regards, -grygorii