Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752102AbcLETi0 (ORCPT ); Mon, 5 Dec 2016 14:38:26 -0500 Received: from mail-io0-f172.google.com ([209.85.223.172]:35038 "EHLO mail-io0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751847AbcLETiY (ORCPT ); Mon, 5 Dec 2016 14:38:24 -0500 MIME-Version: 1.0 In-Reply-To: <62fd5b15-5d1c-d834-97f9-2f6373dc7279@redhat.com> References: <20161201012401.17367-1-jistone@redhat.com> <62fd5b15-5d1c-d834-97f9-2f6373dc7279@redhat.com> From: Kees Cook Date: Mon, 5 Dec 2016 11:38:13 -0800 X-Google-Sender-Auth: AT46oL3jfhFPDjg6NnoJY4Q4xgU Message-ID: Subject: Re: [PATCH] Yama: allow access for the current ptrace parent To: Josh Stone Cc: James Morris , LKML , "Serge E. Hallyn" , linux-security-module Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 642 Lines: 21 On Mon, Dec 5, 2016 at 11:13 AM, Josh Stone wrote: > On 12/02/2016 03:27 PM, Kees Cook wrote: >>> + /* If there's already an active tracing relationship, then make an >> >> I'll adjust the comment style here and add it to my tree for -next. > > Thanks! > > I guess the tweak is that it should have an empty "/*" line? > > FWIW, checkpatch.pl doesn't warn about this -- perhaps it should? > I only see the opposite check for NETWORKING_BLOCK_COMMENT_STYLE. Hrm, I thought it did warn. But yeah, the networking subsystem uses this style but everywhere else doesn't. :P Wheee. :) -Kees -- Kees Cook Nexus Security