Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752107AbcLETtP (ORCPT ); Mon, 5 Dec 2016 14:49:15 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:49094 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751512AbcLETtN (ORCPT ); Mon, 5 Dec 2016 14:49:13 -0500 Date: Mon, 05 Dec 2016 14:49:12 -0500 (EST) Message-Id: <20161205.144912.1032798616829972627.davem@davemloft.net> To: bianpan2016@163.com Cc: dmitry.tarnyagin@lockless.no, sergei.shtylyov@cogentembedded.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] net: caif: remove ineffective check From: David Miller In-Reply-To: <1480824944-3439-1-git-send-email-bianpan2016@163.com> References: <1480824944-3439-1-git-send-email-bianpan2016@163.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 05 Dec 2016 10:49:51 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 476 Lines: 12 From: Pan Bian Date: Sun, 4 Dec 2016 12:15:44 +0800 > The check of the return value of sock_register() is ineffective. > "if(!err)" seems to be a typo. It is better to propagate the error code > to the callers of caif_sktinit_module(). This patch removes the check > statment and directly returns the result of sock_register(). > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188751 > Signed-off-by: Pan Bian Applied.