Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752441AbcLEUyL (ORCPT ); Mon, 5 Dec 2016 15:54:11 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:51158 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751320AbcLEUyJ (ORCPT ); Mon, 5 Dec 2016 15:54:09 -0500 Date: Mon, 5 Dec 2016 23:53:48 +0300 From: Dan Carpenter To: Juergen Gross Cc: Quentin Lambert , Boris Ostrovsky , David Vrabel , "James E.J. Bottomley" , "Martin K. Petersen" , xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] xen-scsifront: Add a missing call to kfree Message-ID: <20161205205348.GA31465@mwanda> References: <20161119182256.9081-1-lambert.quentin@gmail.com> <1320a162-dc36-5833-a746-367134dae5e7@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1320a162-dc36-5833-a746-367134dae5e7@suse.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 552 Lines: 19 On Mon, Nov 21, 2016 at 07:01:36AM +0100, Juergen Gross wrote: > On 19/11/16 19:22, Quentin Lambert wrote: > > Most error branches following the call to kmalloc contain > > a call to kfree. This patch add these calls where they are > > missing. > > > > This issue was found with Hector. > > > > Signed-off-by: Quentin Lambert > > Nice catch. I think this will need some more work, I'll do a > follow-on patch. > The error handling is really weird. Could you send your follow on to this thread? regards, dan carpenter