Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752451AbcLEU6F (ORCPT ); Mon, 5 Dec 2016 15:58:05 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:17713 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751563AbcLEU57 (ORCPT ); Mon, 5 Dec 2016 15:57:59 -0500 Date: Mon, 5 Dec 2016 23:57:15 +0300 From: Dan Carpenter To: James Simmons Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Andreas Dilger , Oleg Drokin , wang di , Linux Kernel Mailing List , Lustre Development List Subject: Re: [PATCH 05/22] staging: lustre: lmv: remove nlink check in lmv_revalidate_slaves Message-ID: <20161205205715.GC31465@mwanda> References: <1480726409-20350-1-git-send-email-jsimmons@infradead.org> <1480726409-20350-6-git-send-email-jsimmons@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1480726409-20350-6-git-send-email-jsimmons@infradead.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 540 Lines: 16 On Fri, Dec 02, 2016 at 07:53:12PM -0500, James Simmons wrote: > From: wang di > > Remove nlink < 2 check in lmv_revalidate_slaves, because > after nlink reaches to LDISKFS_LINK_MAX (65000), the inode > nlink will be set to 1. > I don't understand how this changelog matches the patch... The changelog says we're removing a check but really this is a NULL dereference fix, right? We're not really removing a check at all, just changing it for something else. We do remove a printk, though. regards, dan carpenter