Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752423AbcLEVMp (ORCPT ); Mon, 5 Dec 2016 16:12:45 -0500 Received: from lxorguk.ukuu.org.uk ([81.2.110.251]:39194 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751427AbcLEVMn (ORCPT ); Mon, 5 Dec 2016 16:12:43 -0500 Date: Mon, 5 Dec 2016 21:12:27 +0000 From: One Thousand Gnomes To: David Howells Cc: Greg KH , linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, minyard@acm.org Subject: Re: [PATCH 01/39] Annotate module params that specify hardware parameters (eg. ioport) Message-ID: <20161205211227.4cc792d6@lxorguk.ukuu.org.uk> In-Reply-To: <18118.1480608146@warthog.procyon.org.uk> References: <20161201150135.GA10317@kroah.com> <148059537897.31612.9461043954611464597.stgit@warthog.procyon.org.uk> <148059538747.31612.8974972913601108271.stgit@warthog.procyon.org.uk> <18118.1480608146@warthog.procyon.org.uk> Organization: Intel Corporation X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 610 Lines: 16 On Thu, 01 Dec 2016 16:02:26 +0000 David Howells wrote: > Greg KH wrote: > > > Also, I think Alan's comment about it the last time it came up was more like > > a "look at all of the other ways you could do bad things to hardware!" > > comment, not a "you need to also do this thing too!" type of request. In all honesty I think both need to go in together, otherwise the first patch is useless. It's not a case of "oh there may be another obscure exploit .." , this is "I can automate it with a python script, post a CVE, and show I'm awesome" 8) Alan