Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752526AbcLEVY6 (ORCPT ); Mon, 5 Dec 2016 16:24:58 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:34286 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751311AbcLEVYz (ORCPT ); Mon, 5 Dec 2016 16:24:55 -0500 Date: Mon, 5 Dec 2016 22:24:51 +0100 From: Stefan Eichenberger To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli , Andrew Lunn , Richard Cochran Subject: Re: [PATCH v2 net-next v2 3/4] net: dsa: mv88e6xxx: add a soft reset operation Message-ID: <20161205212451.GB6038@eichest-notebook> References: <20161205162703.22567-1-vivien.didelot@savoirfairelinux.com> <20161205162703.22567-4-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161205162703.22567-4-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 597 Lines: 18 Hi Vivien On Mon, Dec 05, 2016 at 11:27:02AM -0500, Vivien Didelot wrote: > static const struct mv88e6xxx_ops mv88e6097_ops = { > @@ -3285,6 +3266,7 @@ static const struct mv88e6xxx_ops mv88e6097_ops = { > .g1_set_cpu_port = mv88e6095_g1_set_cpu_port, > .g1_set_egress_port = mv88e6095_g1_set_egress_port, > .mgmt_rsvd2cpu = mv88e6095_g2_mgmt_rsvd2cpu, > + .reset = mv88e6185_g1_reset, > }; Because it is not necessary to disable/enable the PPU and bit 14 is marked as reserved in the datasheet, I think the following should be used instead: .reset = mv88e6352_g1_reset Regards, Stefan