Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752782AbcLEWSX (ORCPT ); Mon, 5 Dec 2016 17:18:23 -0500 Received: from mail.savoirfairelinux.com ([208.88.110.44]:39036 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751311AbcLEWSV (ORCPT ); Mon, 5 Dec 2016 17:18:21 -0500 From: Vivien Didelot To: Stefan Eichenberger Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli , Andrew Lunn , Richard Cochran Subject: Re: [PATCH v2 net-next v2 4/4] net: dsa: mv88e6xxx: add PPU operations In-Reply-To: <20161205210439.GA6038@eichest-notebook> References: <20161205162703.22567-1-vivien.didelot@savoirfairelinux.com> <20161205162703.22567-5-vivien.didelot@savoirfairelinux.com> <20161205210439.GA6038@eichest-notebook> Date: Mon, 05 Dec 2016 17:18:19 -0500 Message-ID: <874m2ic95g.fsf@ketchup.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 880 Lines: 23 Stefan Eichenberger writes: > Hi Vivien, > > On Mon, Dec 05, 2016 at 11:27:03AM -0500, Vivien Didelot wrote: >> @@ -3266,6 +3220,8 @@ static const struct mv88e6xxx_ops mv88e6097_ops = { >> .g1_set_cpu_port = mv88e6095_g1_set_cpu_port, >> .g1_set_egress_port = mv88e6095_g1_set_egress_port, >> .mgmt_rsvd2cpu = mv88e6095_g2_mgmt_rsvd2cpu, >> + .ppu_enable = mv88e6185_g1_ppu_enable, >> + .ppu_disable = mv88e6185_g1_ppu_disable, >> .reset = mv88e6185_g1_reset, >> }; > > The mv88e6097 should use the indirect access to the phys, bit 14 in g1 > control is marked as reserved. They write in the datasheet that > disabling the PPU is still supported but indirect access via g2 should > be used because disabling the PPU is no longer recommended. Ho ok thanks, I respin a v3 right away with this removed and with mv88e6352_g1_reset instead. Vivien