Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753315AbcLEWbw (ORCPT ); Mon, 5 Dec 2016 17:31:52 -0500 Received: from mail.savoirfairelinux.com ([208.88.110.44]:40530 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753107AbcLEWbg (ORCPT ); Mon, 5 Dec 2016 17:31:36 -0500 From: Vivien Didelot To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli , Andrew Lunn , Stefan Eichenberger , Richard Cochran , Vivien Didelot Subject: [PATCH v3 net-next v3 0/4] net: dsa: mv88e6xxx: rework reset and PPU code Date: Mon, 5 Dec 2016 17:30:24 -0500 Message-Id: <20161205223028.20308-1-vivien.didelot@savoirfairelinux.com> X-Mailer: git-send-email 2.10.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1888 Lines: 45 Old Marvell chips (like 88E6060) don't have a PHY Polling Unit (PPU). Next chips (like 88E6185) have a PPU, which has exclusive access to the PHY registers, thus must be disabled before access. Newer chips (like 88E6352) have an indirect mechanism to access the PHY registers whenever, thus loose control over the PPU (always enabled). Here's a summary: Model | PPU? | Has PPU ctrl? | PPU state readable? | PHY access ----- | ---- | -------------- | ------------------- | ---------- 6060 | no | no | no | direct 6185 | yes | yes, PPUEn bit | yes, PPUState 2-bit | direct w/ PPU dis. 6352 | yes | no | yes, PPUState 1-bit | indirect 6390 | yes | no | yes, InitState bit | indirect Depending on the PPU control, a switch may have to restart the PPU when resetting the switch. Once the switch is reset, we must wait for the PPU state to be active polling again before accessing the registers. For that purpose, add new operations to the chips to enable/disable the PPU, and execute software reset. With these new ops in place, rework the switch reset code and finally get rid of the MV88E6XXX_FLAG_PPU* flags. Changes in v3: - consider 6097 as 6352 (no PPU ops and use mv88e6352_g1_reset). Changes in v2: - wait in ppu/reset ops so that ppu_polling is not needed anymore. Vivien Didelot (4): net: dsa: mv88e6xxx: add helper to disable ports net: dsa: mv88e6xxx: add helper to hardware reset net: dsa: mv88e6xxx: add a soft reset operation net: dsa: mv88e6xxx: add PPU operations drivers/net/dsa/mv88e6xxx/chip.c | 176 +++++++++++++++------------------ drivers/net/dsa/mv88e6xxx/global1.c | 178 ++++++++++++++++++++++++++++++++++ drivers/net/dsa/mv88e6xxx/global1.h | 7 ++ drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 34 +++---- 4 files changed, 276 insertions(+), 119 deletions(-) -- 2.10.2