Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752872AbcLEWoR convert rfc822-to-8bit (ORCPT ); Mon, 5 Dec 2016 17:44:17 -0500 Received: from mga03.intel.com ([134.134.136.65]:28322 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752300AbcLEWoQ (ORCPT ); Mon, 5 Dec 2016 17:44:16 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,749,1477983600"; d="scan'208";a="39213379" Subject: Re: [PATCH 1/1] staging: lustre: lnet: fix improper return value Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: text/plain; charset=us-ascii From: Oleg Drokin In-Reply-To: <1480769575-6074-1-git-send-email-bianpan201602@163.com> Date: Mon, 5 Dec 2016 17:44:09 -0500 Cc: Andreas Dilger , James Simmons , Greg Kroah-Hartman , Lustre Development List , "devel@driverdev.osuosl.org SUBSYSTEM" , Linux Kernel Mailing List , Pan Bian Content-Transfer-Encoding: 8BIT Message-Id: <2DA842C3-D6EF-472B-9187-A6C681ACD863@intel.com> References: <1480769575-6074-1-git-send-email-bianpan201602@163.com> To: Pan Bian X-Mailer: Apple Mail (2.1283) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 861 Lines: 34 On Dec 3, 2016, at 7:52 AM, Pan Bian wrote: > From: Pan Bian > > At the end of function lstcon_group_info(), "return 0" seems improper. > It may be better to return the value of rc. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188811 > > Signed-off-by: Pan Bian Acked-by: Oleg Drokin > --- > drivers/staging/lustre/lnet/selftest/console.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/lustre/lnet/selftest/console.c b/drivers/staging/lustre/lnet/selftest/console.c > index a0fcbf3..9a7c41a 100644 > --- a/drivers/staging/lustre/lnet/selftest/console.c > +++ b/drivers/staging/lustre/lnet/selftest/console.c > @@ -820,7 +820,7 @@ > > lstcon_group_decref(grp); > > - return 0; > + return rc; > } > > static int > -- > 1.9.1 >