Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753319AbcLEXEY (ORCPT ); Mon, 5 Dec 2016 18:04:24 -0500 Received: from mail-oi0-f67.google.com ([209.85.218.67]:35808 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753198AbcLEXEW (ORCPT ); Mon, 5 Dec 2016 18:04:22 -0500 Date: Mon, 5 Dec 2016 17:04:20 -0600 From: Rob Herring To: Raviteja Garimella Cc: Mark Rutland , Greg Kroah-Hartman , Felipe Balbi , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-usb@vger.kernel.org Subject: Re: [PATCH 1/2] Add DT bindings documentation for Synopsys UDC driver Message-ID: <20161205230420.ubo2cskoohfnwlfs@rob-hp-laptop> References: <1480485910-7797-1-git-send-email-raviteja.garimella@broadcom.com> <1480485910-7797-2-git-send-email-raviteja.garimella@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1480485910-7797-2-git-send-email-raviteja.garimella@broadcom.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1910 Lines: 65 On Wed, Nov 30, 2016 at 11:35:09AM +0530, Raviteja Garimella wrote: > This patch adds documentation for Synopsis Designware Cores AHB > Subsystem Device Controller (UDC). > > Signed-off-by: Raviteja Garimella > --- > .../devicetree/bindings/usb/snps,dw-ahb-udc.txt | 29 ++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/snps,dw-ahb-udc.txt > > diff --git a/Documentation/devicetree/bindings/usb/snps,dw-ahb-udc.txt b/Documentation/devicetree/bindings/usb/snps,dw-ahb-udc.txt > new file mode 100644 > index 0000000..64e1fbf > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/snps,dw-ahb-udc.txt > @@ -0,0 +1,29 @@ > +Synopsys USB Device controller. > + > +The device node is used for Synopsys Designware Cores AHB > +Subsystem Device Controller (UDC). > + > +Required properties: > + - compatible: should be "snps,dw-ahbudc" Needs an SoC specific compatible string. > + - reg: Offset and length of UDC register set > + - interrupts: description of interrupt line > + - phys: phandle to phy node. > + - phy-names: name of phy node. Must be usb2drd. A name is pointless when there's only 1 phy. Is this a device or dual role device(DRD)? > + - extcon: phandle to the extcon device I don't think extcon should be required. If this is UDC only, I'm not sure why you'd need it. > + > +Example: > + > + usbdrd_phy: phy@6501c000 { > + #phy-cells = <0>; > + compatible = "brcm,ns2-drd-phy"; > + reg = <0x66000000 0x1000>, > + } > + > + udc_dwc: usb@664e0000 { > + compatible = "snps,dw-ahb-udc"; Doesn't match above. > + reg = <0x664e0000 0x2000>; > + interrupts = ; > + phys = <&usbdrd_phy>; > + phy-names = "usb2drd"; > + extcon = <&usbdrd_phy>"; You are already describing the phy connection, you shouldn't need both. > + }; > -- > 2.1.0 >