Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752335AbcLFBRh (ORCPT ); Mon, 5 Dec 2016 20:17:37 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:24631 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751725AbcLFBRe (ORCPT ); Mon, 5 Dec 2016 20:17:34 -0500 Subject: Re: [net-next][PATCH 02/18] RDS: mark few internal functions static to make sparse build happy To: Sergei Shtylyov , netdev@vger.kernel.org, davem@davemloft.net References: <1480921073-9140-1-git-send-email-santosh.shilimkar@oracle.com> <1480921073-9140-3-git-send-email-santosh.shilimkar@oracle.com> <604d4954-7302-018e-6f9b-71c0aea6509e@cogentembedded.com> Cc: linux-kernel@vger.kernel.org From: Santosh Shilimkar Organization: Oracle Corporation Message-ID: <52e13934-1e59-4166-9ccf-7bfe769d7219@oracle.com> Date: Mon, 5 Dec 2016 17:17:50 -0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <604d4954-7302-018e-6f9b-71c0aea6509e@cogentembedded.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 549 Lines: 20 On 12/5/2016 1:45 AM, Sergei Shtylyov wrote: > Hello! > > On 12/5/2016 9:57 AM, Santosh Shilimkar wrote: > [...] >> -void rds_walk_conn_path_info(struct socket *sock, unsigned int len, >> +static void rds_walk_conn_path_info(struct socket *sock, unsigned int >> len, >> struct rds_info_iterator *iter, >> struct rds_info_lengths *lens, >> int (*visitor)(struct rds_conn_path *, void *), > > You now need to realign the continuation lines. > Right. Will fix that. Thanks !! Regards, Santosh