Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751951AbcLFCOF (ORCPT ); Mon, 5 Dec 2016 21:14:05 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:37245 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752210AbcLFCMu (ORCPT ); Mon, 5 Dec 2016 21:12:50 -0500 Subject: Re: [PATCH v8 2/6] powerpc: pSeries/Kconfig: Add qspinlock build config To: Boqun Feng , Pan Xinhui References: <1480951166-44830-1-git-send-email-xinhui.pan@linux.vnet.ibm.com> <1480951166-44830-3-git-send-email-xinhui.pan@linux.vnet.ibm.com> <20161206005834.GC18164@tardis.cn.ibm.com> <2d4eb891-e999-b7f8-52ff-31ef7bb8af6b@linux.vnet.ibm.com> Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, peterz@infradead.org, mingo@redhat.com, paulmck@linux.vnet.ibm.com, waiman.long@hpe.com, virtualization@lists.linux-foundation.org From: Pan Xinhui Date: Tue, 6 Dec 2016 10:12:56 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <2d4eb891-e999-b7f8-52ff-31ef7bb8af6b@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16120602-0020-0000-0000-00000073B53A X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16120602-0021-0000-0000-0000018A3758 Message-Id: <945a9698-e02e-e004-f1df-cabded4d8398@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-12-05_18:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1612060031 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1690 Lines: 59 在 2016/12/6 09:24, Pan Xinhui 写道: > > > 在 2016/12/6 08:58, Boqun Feng 写道: >> On Mon, Dec 05, 2016 at 10:19:22AM -0500, Pan Xinhui wrote: >>> pSeries/powerNV will use qspinlock from now on. >>> >>> Signed-off-by: Pan Xinhui >>> --- >>> arch/powerpc/platforms/pseries/Kconfig | 8 ++++++++ >>> 1 file changed, 8 insertions(+) >>> >>> diff --git a/arch/powerpc/platforms/pseries/Kconfig b/arch/powerpc/platforms/pseries/Kconfig >>> index bec90fb..8a87d06 100644 >>> --- a/arch/powerpc/platforms/pseries/Kconfig >>> +++ b/arch/powerpc/platforms/pseries/Kconfig >> >> Why here? Not arch/powerpc/platforms/Kconfig? >> >>> @@ -23,6 +23,14 @@ config PPC_PSERIES >>> select PPC_DOORBELL >>> default y >>> >>> +config ARCH_USE_QUEUED_SPINLOCKS >>> + default y >>> + bool "Enable qspinlock" >> >> I think you just enable qspinlock by default for all PPC platforms. I >> guess you need to put >> >> depends on PPC_PSERIES || PPC_POWERNV >> >> here to achieve what you mean in you commit message. >> oh, yes, need depends on PPC_PSERIES || PPC_POWERNV. > yes, another good way. > I prefer to put it in pseries/Kconfig as same as pv-qspinlocks config. > when we build nv, it still include pSeries's config anyway. > > thanks > xinhui > >> Regards, >> Boqun >> >>> + help >>> + Enabling this option will let kernel use qspinlock which is a kind of >>> + fairlock. It has shown a good performance improvement on x86 and also ppc >>> + especially in high contention cases. >>> + >>> config PPC_SPLPAR >>> depends on PPC_PSERIES >>> bool "Support for shared-processor logical partitions" >>> -- >>> 2.4.11 >>>