Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752514AbcLFEuL (ORCPT ); Mon, 5 Dec 2016 23:50:11 -0500 Received: from mga09.intel.com ([134.134.136.24]:60910 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751670AbcLFEuJ (ORCPT ); Mon, 5 Dec 2016 23:50:09 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,751,1477983600"; d="scan'208";a="37412213" Date: Tue, 6 Dec 2016 10:29:54 +0530 From: Vinod Koul To: Pan Bian Cc: Dan Williams , Dave Jiang , Julia Lawall , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] dmaengine: ioat: set error code on failures Message-ID: <20161206045954.GO6408@localhost> References: <1480690141-2858-1-git-send-email-bianpan2016@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1480690141-2858-1-git-send-email-bianpan2016@163.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 530 Lines: 13 On Fri, Dec 02, 2016 at 10:49:01PM +0800, Pan Bian wrote: > In function ioat_dma_self_test(), when the calls to dma_mapping_error() > fails, the value of return variable err is 0 (indicates no error). As a > result, the return value may be inconsistent with the execution status. > This patch fixes the bug by assigning -ENOMEM to err on the error path. This was v2 of the series so you should tag it as PATCH v2. You can do so with --subject-prefix in git format-patch command. Applied both now with Dave's Acks -- ~Vinod