Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752963AbcLFIcz (ORCPT ); Tue, 6 Dec 2016 03:32:55 -0500 Received: from mail.skyhub.de ([78.46.96.112]:47926 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752041AbcLFIcw (ORCPT ); Tue, 6 Dec 2016 03:32:52 -0500 Date: Tue, 6 Dec 2016 09:32:46 +0100 From: Borislav Petkov To: Andy Lutomirski Cc: x86@kernel.org, One Thousand Gnomes , "linux-kernel@vger.kernel.org" , Brian Gerst , Matthew Whitehead Subject: Re: [RFC PATCH 2/6] x86/cpu: Factor out application of forced cpu caps Message-ID: <20161206083246.sqssrz2vtnj7ufnj@pd.tnic> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20161014 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 947 Lines: 36 On Mon, Dec 05, 2016 at 05:01:11PM -0800, Andy Lutomirski wrote: > There are multiple call sites that apply forced CPU caps. Factor > them into a helper. > > Signed-off-by: Andy Lutomirski > --- > arch/x86/kernel/cpu/common.c | 21 +++++++++++++-------- > 1 file changed, 13 insertions(+), 8 deletions(-) > > diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c > index 37f031f39e27..347ae0a19380 100644 > --- a/arch/x86/kernel/cpu/common.c > +++ b/arch/x86/kernel/cpu/common.c > @@ -655,6 +655,17 @@ void cpu_detect(struct cpuinfo_x86 *c) > } > } > > +static void apply_forced_caps(struct cpuinfo_x86 *c) > +{ > + int i; > + > + for (i = 0; i < NCAPINTS; i++) { > + c->x86_capability[i] &= ~cpu_caps_cleared[i]; > + c->x86_capability[i] |= cpu_caps_set[i]; > + } > + Superfluous newline. > +} -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.