Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752921AbcLFKIK (ORCPT ); Tue, 6 Dec 2016 05:08:10 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:42206 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751752AbcLFKIE (ORCPT ); Tue, 6 Dec 2016 05:08:04 -0500 Date: Tue, 6 Dec 2016 11:07:31 +0100 From: Greg KH To: kys@microsoft.com Cc: linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, vkuznets@redhat.com, jasowang@redhat.com, leann.ogasawara@canonical.com Subject: Re: [PATCH V2 01/15] Drivers: hv: vmbus: Raise retry/wait limits in vmbus_post_msg() Message-ID: <20161206100731.GA32261@kroah.com> References: <1480797239-10085-1-git-send-email-kys@exchange.microsoft.com> <1480797282-10126-1-git-send-email-kys@exchange.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1480797282-10126-1-git-send-email-kys@exchange.microsoft.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1246 Lines: 27 On Sat, Dec 03, 2016 at 12:34:28PM -0800, kys@exchange.microsoft.com wrote: > From: Vitaly Kuznetsov > > DoS protection conditions were altered in WS2016 and now it's easy to get > -EAGAIN returned from vmbus_post_msg() (e.g. when we try changing MTU on a > netvsc device in a loop). All vmbus_post_msg() callers don't retry the > operation and we usually end up with a non-functional device or crash. > > While host's DoS protection conditions are unknown to me my tests show that > it can take up to 10 seconds before the message is sent so doing udelay() > is not an option, we really need to sleep. Almost all vmbus_post_msg() > callers are ready to sleep but there is one special case: > vmbus_initiate_unload() which can be called from interrupt/NMI context and > we can't sleep there. I'm also not sure about the lonely > vmbus_send_tl_connect_request() which has no in-tree users but its external > users are most likely waiting for the host to reply so sleeping there is > also appropriate. > > Signed-off-by: Vitaly Kuznetsov > Signed-off-by: K. Y. Srinivasan Shouldn't this go to stable kernels so that 4.9 and earlier can work properly on WS2016? thanks, greg k-h