Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752961AbcLFKIN (ORCPT ); Tue, 6 Dec 2016 05:08:13 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:42224 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752090AbcLFKIE (ORCPT ); Tue, 6 Dec 2016 05:08:04 -0500 Date: Tue, 6 Dec 2016 10:59:58 +0100 From: Greg Kroah-Hartman To: James Simmons Cc: devel@driverdev.osuosl.org, Andreas Dilger , Oleg Drokin , Linux Kernel Mailing List , Alexander Boyko , Lustre Development List Subject: Re: [PATCH 14/22] staging: lustre: obd: add callback for llog_cat_process_or_fork Message-ID: <20161206095958.GA9387@kroah.com> References: <1480726409-20350-1-git-send-email-jsimmons@infradead.org> <1480726409-20350-15-git-send-email-jsimmons@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1480726409-20350-15-git-send-email-jsimmons@infradead.org> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 566 Lines: 16 On Fri, Dec 02, 2016 at 07:53:21PM -0500, James Simmons wrote: > From: Alexander Boyko > > Currently llog_process_or_fork() is hard coded to > always pass the function pointer llog_cat_process_cb(). > Change llog_cat_process_or_fork() to pass in any > function pointer which will allow us more options > for llog_cat callback routines in the future. Don't change this until you have an actual user for this. Adding infrastructure that is not used is not ok for a staging driver, or really any kernel driver at all. sorry, greg k-h