Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753342AbcLFL0m (ORCPT ); Tue, 6 Dec 2016 06:26:42 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:56487 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752014AbcLFL0l (ORCPT ); Tue, 6 Dec 2016 06:26:41 -0500 Date: Tue, 6 Dec 2016 12:26:34 +0100 From: Peter Zijlstra To: kan.liang@intel.com Cc: mingo@redhat.com, acme@kernel.org, linux-kernel@vger.kernel.org, alexander.shishkin@linux.intel.com, tglx@linutronix.de, namhyung@kernel.org, jolsa@kernel.org, adrian.hunter@intel.com, wangnan0@huawei.com, mark.rutland@arm.com, andi@firstfloor.org Subject: Re: [PATCH V2 01/13] perf/core: Introduce PERF_RECORD_OVERHEAD Message-ID: <20161206112634.GN3124@twins.programming.kicks-ass.net> References: <1480713561-6617-1-git-send-email-kan.liang@intel.com> <1480713561-6617-2-git-send-email-kan.liang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1480713561-6617-2-git-send-email-kan.liang@intel.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 409 Lines: 12 On Fri, Dec 02, 2016 at 04:19:09PM -0500, kan.liang@intel.com wrote: > @@ -1221,6 +1225,11 @@ static inline bool has_addr_filter(struct perf_event *event) > return event->pmu->nr_addr_filters; > } > > +static inline bool needs_log_overhead(struct perf_event *event) > +{ > + return !!event->attr.overhead; > +} There seems to be exactly one user of that, seems a tad pointless to provide this function.