Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752829AbcLFM2g (ORCPT ); Tue, 6 Dec 2016 07:28:36 -0500 Received: from mail-wj0-f193.google.com ([209.85.210.193]:35739 "EHLO mail-wj0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751471AbcLFM2d (ORCPT ); Tue, 6 Dec 2016 07:28:33 -0500 MIME-Version: 1.0 In-Reply-To: <874m2ic95g.fsf@ketchup.i-did-not-set--mail-host-address--so-tickle-me> References: <20161205162703.22567-1-vivien.didelot@savoirfairelinux.com> <20161205162703.22567-5-vivien.didelot@savoirfairelinux.com> <20161205210439.GA6038@eichest-notebook> <874m2ic95g.fsf@ketchup.i-did-not-set--mail-host-address--so-tickle-me> From: Stefan Eichenberger Date: Tue, 6 Dec 2016 13:27:16 +0100 Message-ID: Subject: Re: [PATCH v2 net-next v2 4/4] net: dsa: mv88e6xxx: add PPU operations To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli , Andrew Lunn , Richard Cochran Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1051 Lines: 28 On 5 December 2016 at 23:18, Vivien Didelot wrote: > Stefan Eichenberger writes: > >> Hi Vivien, >> >> On Mon, Dec 05, 2016 at 11:27:03AM -0500, Vivien Didelot wrote: >>> @@ -3266,6 +3220,8 @@ static const struct mv88e6xxx_ops mv88e6097_ops = { >>> .g1_set_cpu_port = mv88e6095_g1_set_cpu_port, >>> .g1_set_egress_port = mv88e6095_g1_set_egress_port, >>> .mgmt_rsvd2cpu = mv88e6095_g2_mgmt_rsvd2cpu, >>> + .ppu_enable = mv88e6185_g1_ppu_enable, >>> + .ppu_disable = mv88e6185_g1_ppu_disable, >>> .reset = mv88e6185_g1_reset, >>> }; >> >> The mv88e6097 should use the indirect access to the phys, bit 14 in g1 >> control is marked as reserved. They write in the datasheet that >> disabling the PPU is still supported but indirect access via g2 should >> be used because disabling the PPU is no longer recommended. > > Ho ok thanks, I respin a v3 right away with this removed and with > mv88e6352_g1_reset instead. Perfect thank you, now it's fine. Regards, Stefan