Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932105AbcLFP24 (ORCPT ); Tue, 6 Dec 2016 10:28:56 -0500 Received: from foss.arm.com ([217.140.101.70]:44246 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752902AbcLFP2w (ORCPT ); Tue, 6 Dec 2016 10:28:52 -0500 Date: Tue, 6 Dec 2016 15:28:38 +0000 From: Will Deacon To: Catalin Marinas Cc: Maninder Singh , mark.rutland@arm.com, wangkefeng.wang@huawei.com, kvm@vger.kernel.org, rkrcmar@redhat.com, kvmarm@lists.cs.columbia.edu, panand@redhat.com, cpgs@samsung.com, shijie.huang@arm.com, labbott@redhat.com, Vaneet Narang , cmetcalf@mellanox.com, marc.zyngier@arm.com, ajeet.y@samsung.com, sandeepa.s.prabhu@gmail.com, linux-arm-kernel@lists.infradead.org, pankaj.m@samsung.com, ard.biesheuvel@linaro.org, linux-kernel@vger.kernel.org, james.morse@arm.com, pbonzini@redhat.com, akpm@linux-foundation.org, christoffer.dall@linaro.org Subject: Re: [PATCH 1/1] arm64: Correcting format specifier for printing 64 bit addresses Message-ID: <20161206152837.GM2498@arm.com> References: <1480925393-8386-1-git-send-email-maninder1.s@samsung.com> <20161205112421.GB14058@arm.com> <20161206152637.GC16701@e104818-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161206152637.GC16701@e104818-lin.cambridge.arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1445 Lines: 41 On Tue, Dec 06, 2016 at 03:26:37PM +0000, Catalin Marinas wrote: > On Mon, Dec 05, 2016 at 11:24:21AM +0000, Will Deacon wrote: > > On Mon, Dec 05, 2016 at 01:39:53PM +0530, Maninder Singh wrote: > > > This patch corrects format specifier for printing 64 bit addresses. > > > > > > Signed-off-by: Maninder Singh > > > Signed-off-by: Vaneet Narang > > > --- > > > arch/arm64/kernel/signal.c | 2 +- > > > arch/arm64/kvm/sys_regs.c | 8 ++++++-- > > > arch/arm64/mm/fault.c | 15 ++++++++++----- > > > arch/arm64/mm/mmu.c | 4 ++-- > > > 4 files changed, 19 insertions(+), 10 deletions(-) > > > > Any reason not to fix kvm/trace.h too? > > If the KVM guys are ok, I can fold the hunk below into this patch: > > diff --git a/arch/arm64/kvm/trace.h b/arch/arm64/kvm/trace.h > index 7fb0008c4fa3..e117123d414b 100644 > --- a/arch/arm64/kvm/trace.h > +++ b/arch/arm64/kvm/trace.h > @@ -20,7 +20,7 @@ TRACE_EVENT(kvm_wfx_arm64, > __entry->is_wfe = is_wfe; > ), > > - TP_printk("guest executed wf%c at: 0x%08lx", > + TP_printk("guest executed wf%c at: 0x%016lx", > __entry->is_wfe ? 'e' : 'i', __entry->vcpu_pc) > ); > > @@ -40,7 +40,7 @@ TRACE_EVENT(kvm_hvc_arm64, > __entry->imm = imm; > ), > > - TP_printk("HVC at 0x%08lx (r0: 0x%08lx, imm: 0x%lx)", > + TP_printk("HVC at 0x%016lx (r0: 0x%016lx, imm: 0x%lx)", Not sure we need the 016 prefix for r0. Will