Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753500AbcLFPa3 (ORCPT ); Tue, 6 Dec 2016 10:30:29 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:47632 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751277AbcLFPa1 (ORCPT ); Tue, 6 Dec 2016 10:30:27 -0500 Subject: Re: [PATCHSET/RFC v2] Make legacy IO schedulers work with blk-mq To: Paolo Valente References: <1480962426-15767-1-git-send-email-axboe@fb.com> CC: Jens Axboe , , Linux-Kernal , Mark Brown , Ulf Hansson , Linus Walleij From: Jens Axboe Message-ID: <84313e6b-c0c8-8713-2ad6-b4c3ff52e011@fb.com> Date: Tue, 6 Dec 2016 08:29:53 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [216.160.245.98] X-ClientProxiedBy: DM3PR12CA0041.namprd12.prod.outlook.com (10.164.12.179) To BN6PR15MB1185.namprd15.prod.outlook.com (10.172.205.139) X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1185;2:+WbUT69xRZM5JE9ylCvy+8UllOVlkvwPHCr2sCKkqp8Enm9sdEBkLrSb9jME8AWiO0OwR5iyNARtkag5jdPtGO5XgezbSQzDBumaB4MvOfFwlZLE3deLLFq6C28VTWlYXJ2eiFZ5ehTyCWP7lvsYk24pETYEIrTlRde5xWm5yHo=;3:SQnaI3ala7BFKXw0wXgkOnwzne5RyYAcVsIw20ap2GhmvhjLYtIOnYUriTl3ndFZiFz4r1LNBdsvn/bqpDhDzAzFzrK6AJOAMxHKQCXE42KoSFUHB8IrGJdnIOkr9J/SFnRHldWnqCULc7UCzKZdL4RAEM3PHRT+as/5Hcm8GHY=;25:PbLYTygU//V6cDzXFaKpRUusHq4IGCLW1WadzJazVJ+OYFXyCoMMZLuZ4SMZcOJADqwHFno114idLybv9UEURdCL4CcaywBjRNnuJmIEPuiJW+d0DhiSgNVpLKFvlKEiFHBFtIyvkfuVQLbY+rX85mXYNWrAVngOfTpFsbeAUIyRdXPEJtIVlVSVTHhBdUmx+GiL0jJJuGekM/CxRO+WGHGYM8+HZh564KXATanhQHu1gX5EyJlS1zTL2uEiCbrjbKmTwLRnJVWF5QYEN85FjIE7q2OVezlrf9Z42m+rZJ3MfQbJ6Bm8DliY9Ws1hREsabgPjF2EAwFKSFm5S8GB3QDpfcXN9xE0Htcf6Ah+6MMjV3nJjNNcC0NuSRPG0/prq35exw/COjopLiY6AedSfooNDIjwJbPaG2RA70tWfh2bkgFgaI48vhnhS4+3RQn+9hgRR3vJXe5KqWd6ob6hvg== X-MS-Office365-Filtering-Correlation-Id: 994cd994-6d04-4a6e-6350-08d41decbcba X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BN6PR15MB1185; X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1185;31:jt+Hownth6ka4woBOzQbtJcIXFCivJKtTfuLWwdYVLry4QmuR+ngmHsk8isZy4yKp8OsJvbmU/kDUsRzMAluAk94FQ9fASTtYEN2HZ9UegPtw+ouzoJLtUuzsNaRJsGj5zMM55Z8qcNdC95LAxigq/KSxrSGHcCb1Yjli1qYBDUPuePAPb8iNyjYWOq6K9bDKeSqVezu2QUWPe1Z+W1wxe3NWoAGIKfIeW7NoAYB2s4z1mGHZy+9pxIGOApOhSB6/HeldE6cmXTErSvfItX6iA==;20:w/lzINeCg3I8PyYB3P8lbRpUWlNDA+0G0cfUUQIuyXSs0dZ2mbp1b2FxRLeNMzKN+5ogmQp1AsPKUVyWGt+dL3loJs4ovhw3VP7vp1MZgbGplf+R2k9pdUFAi+zgsi8xQNNq1R1EL3c4Z7ruKFwaXAiPYOugnCMmbEBLLEUbdEutT7nKoeA9SeufsloDeLzeRqAGM7llNniG/TO/zFyC409vNugAStx3Ts6XVXya0lIFiy8wPMViEnYYWomGnRQf X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(20558992708506)(67672495146484); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(20161123560025)(20161123564025)(20161123562025)(20161123555025)(6072148);SRVR:BN6PR15MB1185;BCL:0;PCL:0;RULEID:;SRVR:BN6PR15MB1185; X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1185;4:fotoHXqELhGBx/1gCsBJLZJdT4t5YgIy//SYY8pF65do3IGA3i1zlV6VVl08ihzNKtary89rssjlJ+Kg42p4DwDregcfUGEJF8eQTWUC1IftzZPK+FI1zSMzjlqbQHThgC3ld3oGcuE/h0cjfGVyHUvFlZGt/YzBpgu/6OiW4KD5ccrHqd7RCi+9X01plNzUcwP9KhZPkKdUs8R4YBvOi9D9hcJ4H7nOYOcPHv+sJd01EurP0qVLVUOigjTYZRiAwIdcUsZ99ZQ8psjvg7pN6CMsslI1+o9VEbc5bASMoRwkPgk17Dz0CqzRP3fdtwBlEG1mdqGbZ27wfdE6B1YdyuGnUAeXDIOCiqk/xg/wKOwlu+nnF2sETcvzisA3lzF6+yXwfoTHp8MW5ryOPs08wFy9K2T/1mb3o+E3UHVYYpja0lZdn0n0RJKBAolsOUxXqisoRLfVx/i4IxKpak3Cjt6BpGm/2gTEKmyvXo1oDXS58x39Z4oEW0Xy5EVx6fhV0DXRkEbdJf+PqI92iYcx5V+KY7p1XArEisNooiR9AfWmWEwcOrV6+aJ9iV+QlPAFbtJRdC+pUzXyAhWUUMhuz6Eopw7JPWMVVmcZyTqWTR+PCPkoB3QoyviLLV6g2WubQ/r+ECku4wZA0f03K3j3Lg== X-Forefront-PRVS: 01480965DA X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(199003)(377454003)(189002)(24454002)(86362001)(230700001)(50986999)(66066001)(33646002)(4326007)(39840400001)(65956001)(81156014)(31686004)(305945005)(117156001)(7846002)(7736002)(81166006)(3846002)(39860400001)(6116002)(5660300001)(83506001)(68736007)(2906002)(64126003)(65806001)(39410400001)(97736004)(39450400002)(77096006)(189998001)(4001350100001)(101416001)(8676002)(47776003)(23746002)(31696002)(50466002)(6666003)(65826007)(110136003)(92566002)(229853002)(6486002)(106356001)(733004)(105586002)(90366009)(36756003)(6916009)(38730400001)(39850400001)(2950100002)(76176999)(42186005)(54356999)(6606295002);DIR:OUT;SFP:1102;SCL:1;SRVR:BN6PR15MB1185;H:[192.168.1.129];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN6PR15MB1185;23:yA1KU2F7oUgk0m/UWnXn+DCxq063qusf33XD2?= =?Windows-1252?Q?A1c1ncAh7E6u5lwspDnXSQkUBZj4YAy1yFenMW/G7kwGw/zudugyioP/?= =?Windows-1252?Q?ykrarPaissxHhiTcdekNJ3pGivUaK++WaAgtXEl1etd5Lo88qarZay0K?= =?Windows-1252?Q?sQMo+ZRpOmq2lct5P+2dMxA6TI0I2FAZAleaLjnqu5Gt1k2vBXXFPyoH?= =?Windows-1252?Q?NxKtYkOyg2lg3OnwFUy/4sm5jfOOyWgaS4Bi3H9okdIWvwL8pDpDm5xu?= =?Windows-1252?Q?4QD9r3CNFSx95LOu+UGkDndT83T5QjXwIjTtzBjLdxwZ+KoVHcqcG9Q4?= =?Windows-1252?Q?VxeQvCZzdJSokd/yvHVu6gCQ0ZgqnVRIsktugm3T8WgIWrjB/+aXXNil?= =?Windows-1252?Q?yAWGeDhR9+U6mzsfeHzaAB7PZaS5m2fqvKLWIoOIYxY7+cH59NhJlYbf?= =?Windows-1252?Q?iNJEJWfiM8jzRfeSke4K+QLJUJMZcvDd7I/SYXQj+hUNRAOlpIYWQ4YY?= =?Windows-1252?Q?hQRccwlB3cy4oiTOwpoOgECDKNYnVIA9nxGA+K2KHI9jjUV1DaPwDP40?= =?Windows-1252?Q?0IRTdiohxbqidxWs6wrwy+ubljvQV1HL/lIdZ6YV/7gxrWFMuSPbRn3q?= =?Windows-1252?Q?KovE+BuNUE/EIqQfk6Eka7PabsyMiAZTMewWdYF6x2nMhhC7MN45SOe3?= =?Windows-1252?Q?oJrwjOegxWWznzCtZntXIs1WLQw/byPb/6J74XNAMq6bVlyxE/zdz0cM?= =?Windows-1252?Q?L8wDOKjbekWRmpmkkDwflLOzzuojbuPbDyUuYItdotmhsKyM9UgdYz5B?= =?Windows-1252?Q?2Is9woHLj+HBGA/rZHJcmlQL1s61AJlRRd/xzAAdQBOzBaOZe6DvyjrL?= =?Windows-1252?Q?0YE2geo1A3AN2wRMt+FYu+T0TAexGmXtVWyoUB5NT9lMxsylImQlcwir?= =?Windows-1252?Q?8sS5oays2eHTys9ZTxytb/j9z02CtFH0+XJEk8GQ0Z0t7I0coTIGIlug?= =?Windows-1252?Q?JRGczkfW0AleKgY/jNPalT0Nycvy0L5U1Y0KZCL2n5eY+a+IZPXDqu5B?= =?Windows-1252?Q?u6vTqLXRcvZ9kEjUvxw1HQODTrWEMkxGrnIylTZIsD5RWgCIE4G2kSAe?= =?Windows-1252?Q?W+6f7owqf1ch81fL49JgaCNRoMAeUjTL5B5xArN8URUsJj5EbIzPveUT?= =?Windows-1252?Q?36U/pNXE2dAx6ajLMS40peN+0x3B/K6Wp0CYvn4T2quwxYrMpLPqYCjY?= =?Windows-1252?Q?B8T/POh3D+MiOXJ7wAe54Zlr/OsUSca//QB09UVuV/QCLrzKP4TGBrgu?= =?Windows-1252?Q?m14OsUQZyIxaE5gS4Rr+0rW95mZLXBybTg6WsSCL3cSQIBU3y5wFDUTO?= =?Windows-1252?Q?2ZVUCT7Y098ilSowAWCR9Y0uTE1SbzUUBgnCfi/IwN9NKxDV8Xt4H85H?= =?Windows-1252?Q?FWAJaiHKBYeBZEt4AQyDi1Vfulma2MOehM6K6m/dxY6AWXrQzKFBPdZR?= =?Windows-1252?Q?A4+fW1e7M060Oss++JgEKwc7RyXELDdeKGIKghlJqAglWdOHkQepjx9c?= =?Windows-1252?Q?TtBBL6gS3NY97sstA3OkVZISU4ue6cUw/njGz3lY/1HfLf+aYFt5kEAa?= =?Windows-1252?Q?TkIdhNQoSh2UkGHsDFdqk0Zj+dNOXC8FFwUvmY2/xIOhUrW7C7prmpnS?= =?Windows-1252?Q?RPQj/YBAA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1185;6:eAwQ4sOaVLj5ICuCN5czgMDfYJG/SC7vSPQDl5xfRCNCncsMGaBGSzot4jdtR7X0urH9uA0mmBngXsgBaJENyFcsqP19gDZvfO6RWrKNt3Ix4VQVw40rAK9sBnsyLz6IRRdCdqd+t1TySEZqID23N0cmvPU79B5HKwxt8xF99jmCWVvYz3R+hU1QWeYIFhUcp97V0TuktzrjhM4Fadm1aG6HhCB71UmJppJYgSPeYAYyEjPF39iW4GHUBklrmcZfNmnN3XA91niKPGJMfhkhzoPXbLjPE/VUv0M/tg4BnXifS2Rxhe0paqG3HdfteysXjuY1dmk5/dU45OtYP1mBzXwhw1ZojzNsHFnOFly1WmY=;5:Ac6ouqntq7nGuJdXOUjq98yxldy4uO4AQ9vUc/6G8jb41J2ySTq8oy3c0+8v6/S/5EolRQhnRV8dRRvB87eRnKnT7f7Nzw+Pm5sFwTDYR55YbdgX5CUnnCZ+j1mKtK6pxvSj1qjNrcSntMB9J92CNw==;24:e9Jztz4lA1g1Wjw3gBaDnm82ojVRi8J8G7zVU3Ir68T6u2bwF+UGcgoSrqvI3L4SY2CA5flJ4XxG2eSy3S1p/ctBace32++v4nl0LwSrRWo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1185;7:5GUGsS8VxJrwciI+A6OXlooKgOSCMbsW2oFREJX/kF56E7cpYMNncnSydP22UfzmgderecGHWtJMFttmDYLTq0FciUNNXTKNLuKKxKvpP25przz/+fZVmtFjtJ2aY7pyxvuocURPLQqYX//cbXRcWjhMvTwIjV1KFlbRnGiHge/QEYH1yAEY+XPy7W4MALtNctybioFP6chHIyBNi2xy/gvnwYf0VwSDS6Oe2qeehh00L8kRozWfOcKqH007oKwo1TQCzLPmucJ9SXr9ZjdPZEJwDw9gCNxGtwwVXmI20SM6+yaEqo2+4RdHqdRY9MaRgZigwD7L9a+3SMMApDazQp15O6p4KFRLJRree5AtaUU=;20:SzaxLmVufmnN2acG1vJq/EKLVbxIpG/wj2T1flsVP6X4m2UgVBPiiZvM2i1SQelciwhP3OK1hQd7YXntXC8qcaiLG74odfbWP3U7q92JyVr1wq9Hv1dLsJxqNjgD5Tm39VMLXgy41Atex8UzIB1ixoYLRsjBsdnpTLR2htumFGQ= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2016 15:29:57.4555 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR15MB1185 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-12-06_09:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1376 Lines: 44 On 12/06/2016 03:01 AM, Paolo Valente wrote: > >> Il giorno 05 dic 2016, alle ore 19:26, Jens Axboe ha scritto: >> >> Version 2 of the hack/patchset, that enables blk-mq to use the legacy >> IO schedulers with single queue devices. Original posting is here: >> >> https://marc.info/?l=linux-block&m=148073493203664&w=2 >> >> You can also found this version in the following git branch: >> >> git://git.kernel.dk/linux-block blk-mq-legacy-sched.2 >> >> and new developments/fixes will happen in the 'blk-mq-legacy-sched' >> branch. >> > > Hi Jens, > while running some tests, the system hung after a while. > > If I'm not mistaken, the above branches contain a (modified) 4.9-rc1. > Maybe instability follows from that? I have tried a rebase, but > resulting conflicts are non-trivial (for me) to solve. > > Meanwhile, if you deem it useful, I can provide you with the oops > message, as I catch it. Please do. I run my testing with master pulled in, but I can rebase the branch to include that. > As a secondary issue, iostat always reports 0 MB/s for both reads and > writes, while tps are non null. Looks like only the inflight stuff worked, but the completion bytes. Let me fix that up. Done. OK, pull from: git://git.kernel.dk/linux-block blk-mq-legacy-sched and you'll get the latest and greatest, and merged to 4.9-rc8 as well. -- Jens Axboe