Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753767AbcLFPef (ORCPT ); Tue, 6 Dec 2016 10:34:35 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:41852 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753647AbcLFPed (ORCPT ); Tue, 6 Dec 2016 10:34:33 -0500 Date: Tue, 06 Dec 2016 10:34:31 -0500 (EST) Message-Id: <20161206.103431.1801934560152684508.davem@davemloft.net> To: niklas.cassel@axis.com Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com, niklass@axis.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: stmmac: clear reset value of snps,wr_osr_lmt/snps,rd_osr_lmt before writing From: David Miller In-Reply-To: <1480957974-22326-1-git-send-email-niklass@axis.com> References: <1480957974-22326-1-git-send-email-niklass@axis.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 06 Dec 2016 06:35:11 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 754 Lines: 20 From: Niklas Cassel Date: Mon, 5 Dec 2016 18:12:54 +0100 > From: Niklas Cassel > > WR_OSR_LMT and RD_OSR_LMT have a reset value of 1. > Since the reset value wasn't cleared before writing, the value in the > register would be incorrect if specifying an uneven value for > snps,wr_osr_lmt/snps,rd_osr_lmt. > > Zero is a valid value for the properties, since the databook specifies: > maximum outstanding requests = WR_OSR_LMT + 1. > > We do not want to change the behavior for existing users when the > property is missing. Therefore, default to 1 if the property is missing, > since that is the same as the reset value. > > Signed-off-by: Niklas Cassel Applied, thank you.