Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753129AbcLFPqa (ORCPT ); Tue, 6 Dec 2016 10:46:30 -0500 Received: from mail-db5eur01on0040.outbound.protection.outlook.com ([104.47.2.40]:20352 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751492AbcLFPq2 (ORCPT ); Tue, 6 Dec 2016 10:46:28 -0500 From: Laurentiu Tudor To: Dan Carpenter CC: Stuart Yoder , "gregkh@linuxfoundation.org" , "devel@driverdev.osuosl.org" , "agraf@suse.de" , "Ruxandra Ioana Radulescu" , "arnd@arndb.de" , Roy Pledge , "linux-kernel@vger.kernel.org" , Leo Li , Catalin Horghidan , "Ioana Ciornei" Subject: Re: [PATCH v3 4/9] bus: fsl-mc: dpio: add frame descriptor and scatter/gather APIs Thread-Topic: [PATCH v3 4/9] bus: fsl-mc: dpio: add frame descriptor and scatter/gather APIs Thread-Index: AQHSTCUaCEB5oHIlGEuMuDHAKEUYKKD0klaAgAVIVwCAAOYYAA== Date: Tue, 6 Dec 2016 10:35:59 +0000 Message-ID: <5846948E.10203@nxp.com> References: <1480632094-3621-1-git-send-email-stuart.yoder@nxp.com> <1480632094-3621-5-git-send-email-stuart.yoder@nxp.com> <5841651D.5080703@nxp.com> <20161205205226.GB31322@mwanda> In-Reply-To: <20161205205226.GB31322@mwanda> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=laurentiu.tudor@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [192.88.146.1] x-microsoft-exchange-diagnostics: 1;VI1PR0401MB2640;7:DmuUZMBY03ThBpYxwccMujd8IETYgYORZc/Q6dILDBbOC6nXJN6yUfPW5SM8snyiTni1GhOVGu2z4YCbGxnL9JEHZsKH5up+KSzlgmoZUoO+O8qYgLTzXkapfitbRZ4TRgdjEr8wJwWaNQRsS4kaOGzTSAaYUD/hQXA2xHinMaCIRWEBwHZJ8MnM7slegyHsf+aQ7lab+b+4+ssTHTq6Vri6aMyBAV+HqztGFLmI/MFGAzykpiBUI7tB8oulyo/Y7DG1E5/R4lwLzpZ50gNHpdN6Wuw4HZdcR/L9GVqJjX4MwKFgTtCQjQFBrjRcfuUD22EemCQ5s7CoAv26P4Zx18m+rJhDKNN/ZLw/0Jczd+YhcCPNJaphME0beWIjMOWKow56Ev6lY6o2X11J4eyAlNMRahKKvkSDvuQm3XCu8YcBPTxb9taQ747rvdJIj6gZpiMMUsjYXaVLS1TcfxeiuQ== x-forefront-antispam-report: SFV:SKI;SCL:-1SFV:NSPM;SFS:(10009020)(6009001)(7916002)(377454003)(24454002)(199003)(189002)(33656002)(36756003)(92566002)(106356001)(106116001)(76176999)(54356999)(122556002)(50986999)(105586002)(2900100001)(5660300001)(2950100002)(101416001)(110136003)(6916009)(229853002)(65816999)(66066001)(86362001)(39840400001)(39850400001)(6512006)(39860400001)(38730400001)(39450400002)(77096006)(6506006)(6486002)(39410400001)(189998001)(7846002)(7736002)(68736007)(305945005)(81156014)(8936002)(8676002)(97736004)(4326007)(3660700001)(81166006)(93886004)(3280700002)(2906002)(6116002)(3846002)(102836003);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0401MB2640;H:VI1PR0401MB1856.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; x-ms-office365-filtering-correlation-id: 48851d43-3044-4a7b-998b-08d41dc3ab75 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:VI1PR0401MB2640; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026)(6041248)(20161123555025)(20161123564025)(20161123560025)(20161123562025)(6047074)(6072148);SRVR:VI1PR0401MB2640;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0401MB2640; x-forefront-prvs: 01480965DA spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="Windows-1252" Content-ID: <32315B8F07DEE848AE17881988DDD02B@eurprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Dec 2016 10:35:59.6910 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2640 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uB6FkaEk001630 Content-Length: 600 Lines: 16 On 12/05/2016 10:52 PM, Dan Carpenter wrote: > On Fri, Dec 02, 2016 at 12:12:14PM +0000, Laurentiu Tudor wrote: >>> +static inline bool dpaa2_sg_is_final(const struct dpaa2_sg_entry *sg) >>> +{ >>> + return !!(le16_to_cpu(sg->format_offset) >> SG_FINAL_FLAG_SHIFT); >> >> In other places in this file we don't use the '!!' to convert to bool. Maybe we should drop it here too. > > I like the explicit "!!". I think it makes the code more obvious since > all the information is on one line. > That's fine too, as long as we're doing it consistently in all the places. --- Best Regards, Laurentiu