Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753016AbcLFQaL (ORCPT ); Tue, 6 Dec 2016 11:30:11 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:42868 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751618AbcLFQaJ (ORCPT ); Tue, 6 Dec 2016 11:30:09 -0500 Date: Tue, 06 Dec 2016 11:30:04 -0500 (EST) Message-Id: <20161206.113004.1297109434722530511.davem@davemloft.net> To: LinoSanfilippo@gmx.de Cc: charrer@alacritech.com, liodot@gmail.com, gregkh@linuxfoundation.org, andrew@lunn.ch, roszenrami@gmail.com, markus.boehme@mailbox.org, f.fainelli@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: Gigabit ethernet driver for Alacritechs SLIC devices (v4) From: David Miller In-Reply-To: <1480975637-18245-1-git-send-email-LinoSanfilippo@gmx.de> References: <1480975637-18245-1-git-send-email-LinoSanfilippo@gmx.de> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 06 Dec 2016 07:30:47 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 761 Lines: 18 From: Lino Sanfilippo Date: Mon, 5 Dec 2016 23:07:15 +0100 > this is the forth version of the slicoss gigabit ethernet driver (which is a > rework of the driver from Alacritech which can currently be found under > drivers/staging/slicoss). The driver is supposed to support Mojave, Oasis and > Kalahari cards, for both copper and fiber. > > If this code is accepted the staging version can be removed. > > The driver has been tested on a SEN2104ET adapter (4 Port PCIe copper). I've applied this series, nice work. But realize that if you use SLICOSS as the Kconfig symbol to select this driver, then while the staging driver is still in the tree it will enable both drivers which both want to attach to the same exact device IDs.