Date: Tue, 06 Dec 2016 11:46:51 -0500 (EST)
Message-Id: <20161206.114651.746543628535484734.davem@davemloft.net>
To: gregkh@linuxfoundation.org
Cc: LinoSanfilippo@gmx.de, charrer@alacritech.com, liodot@gmail.com,
        andrew@lunn.ch, roszenrami@gmail.com, markus.boehme@mailbox.org,
        f.fainelli@gmail.com, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: Gigabit ethernet driver for Alacritechs SLIC devices (v4)
From: David Miller <davem@davemloft.net>
In-Reply-To: <20161206164039.GA7091@kroah.com>
References: <1480975637-18245-1-git-send-email-LinoSanfilippo@gmx.de>
        <20161206.113004.1297109434722530511.davem@davemloft.net>
        <20161206164039.GA7091@kroah.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1136
Lines: 28

From: Greg KH <gregkh@linuxfoundation.org>
Date: Tue, 6 Dec 2016 17:40:39 +0100

> On Tue, Dec 06, 2016 at 11:30:04AM -0500, David Miller wrote:
>> From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
>> Date: Mon,  5 Dec 2016 23:07:15 +0100
>> 
>> > this is the forth version of the slicoss gigabit ethernet driver (which is a
>> > rework of the driver from Alacritech which can currently be found under
>> > drivers/staging/slicoss). The driver is supposed to support Mojave, Oasis and
>> > Kalahari cards, for both copper and fiber.
>> > 
>> > If this code is accepted the staging version can be removed.
>> > 
>> > The driver has been tested on a SEN2104ET adapter (4 Port PCIe copper).
>> 
>> I've applied this series, nice work.
>> 
>> But realize that if you use SLICOSS as the Kconfig symbol to select
>> this driver, then while the staging driver is still in the tree it
>> will enable both drivers which both want to attach to the same exact
>> device IDs.
> 
> If you have taken this in your tree now, I will go delete the staging
> driver from the staging tree, so we will not have that issue.  Should I
> do that now?

Please do.