Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753709AbcLFRau (ORCPT ); Tue, 6 Dec 2016 12:30:50 -0500 Received: from foss.arm.com ([217.140.101.70]:48612 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751729AbcLFRas (ORCPT ); Tue, 6 Dec 2016 12:30:48 -0500 Subject: Re: [RFC v3 04/10] iommu: iommu_alloc_resv_region To: Eric Auger , eric.auger.pro@gmail.com, christoffer.dall@linaro.org, marc.zyngier@arm.com, alex.williamson@redhat.com, will.deacon@arm.com, joro@8bytes.org, tglx@linutronix.de, jason@lakedaemon.net, linux-arm-kernel@lists.infradead.org References: <1479215363-2898-1-git-send-email-eric.auger@redhat.com> <1479215363-2898-5-git-send-email-eric.auger@redhat.com> Cc: kvm@vger.kernel.org, drjones@redhat.com, linux-kernel@vger.kernel.org, pranav.sawargaonkar@gmail.com, iommu@lists.linux-foundation.org, punit.agrawal@arm.com, diana.craciun@nxp.com From: Robin Murphy Message-ID: <25fd2c22-1e4d-dd6b-d9fa-e3ad3573abf9@arm.com> Date: Tue, 6 Dec 2016 17:30:44 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1479215363-2898-5-git-send-email-eric.auger@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2351 Lines: 71 On 15/11/16 13:09, Eric Auger wrote: > Introduce a new helper serving the purpose to allocate a reserved > region. This will be used in iommu driver implementing reserved > region callbacks. > > Signed-off-by: Eric Auger > --- > drivers/iommu/iommu.c | 16 ++++++++++++++++ > include/linux/iommu.h | 8 ++++++++ > 2 files changed, 24 insertions(+) > > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c > index c7ed334..6ee529f 100644 > --- a/drivers/iommu/iommu.c > +++ b/drivers/iommu/iommu.c > @@ -1562,6 +1562,22 @@ void iommu_put_resv_regions(struct device *dev, struct list_head *list) > ops->put_resv_regions(dev, list); > } > > +struct iommu_resv_region *iommu_alloc_resv_region(phys_addr_t start, > + size_t length, > + unsigned int prot) > +{ > + struct iommu_resv_region *region; > + > + region = kzalloc(sizeof(*region), GFP_KERNEL); > + if (!region) > + return NULL; > + > + region->start = start; > + region->length = length; > + region->prot = prot; > + return region; > +} I think you need an INIT_LIST_HEAD() in here as well, or CONFIG_DEBUG_LIST might get unhappy about using an uninitialised head later. Robin. > + > /* Request that a device is direct mapped by the IOMMU */ > int iommu_request_dm_for_dev(struct device *dev) > { > diff --git a/include/linux/iommu.h b/include/linux/iommu.h > index 02cf565..0aea877 100644 > --- a/include/linux/iommu.h > +++ b/include/linux/iommu.h > @@ -241,6 +241,8 @@ extern void iommu_set_fault_handler(struct iommu_domain *domain, > extern void iommu_get_resv_regions(struct device *dev, struct list_head *list); > extern void iommu_put_resv_regions(struct device *dev, struct list_head *list); > extern int iommu_request_dm_for_dev(struct device *dev); > +extern struct iommu_resv_region * > +iommu_alloc_resv_region(phys_addr_t start, size_t length, unsigned int prot); > > extern int iommu_attach_group(struct iommu_domain *domain, > struct iommu_group *group); > @@ -454,6 +456,12 @@ static inline void iommu_put_resv_regions(struct device *dev, > { > } > > +static inline struct iommu_resv_region * > +iommu_alloc_resv_region(phys_addr_t start, size_t length, unsigned int prot) > +{ > + return NULL; > +} > + > static inline int iommu_request_dm_for_dev(struct device *dev) > { > return -ENODEV; >