Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753412AbcLFRbz (ORCPT ); Tue, 6 Dec 2016 12:31:55 -0500 Received: from mail-oi0-f68.google.com ([209.85.218.68]:33588 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751563AbcLFRbx (ORCPT ); Tue, 6 Dec 2016 12:31:53 -0500 MIME-Version: 1.0 In-Reply-To: References: <20161206171714.22738-1-zajec5@gmail.com> <20161206171714.22738-2-zajec5@gmail.com> From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Date: Tue, 6 Dec 2016 18:31:52 +0100 Message-ID: Subject: Re: [PATCH 2/5] ARM: BCM5301X: Specify USB controllers in DT To: Ray Jui Cc: Florian Fainelli , Arnd Bergmann , Rob Herring , Mark Rutland , Russell King , Hauke Mehrtens , bcm-kernel-feedback-list , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Linux Kernel Mailing List , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uB6HW0iL014925 Content-Length: 1748 Lines: 49 On 6 December 2016 at 18:28, Ray Jui wrote: > On 12/6/2016 9:17 AM, Rafał Miłecki wrote: >> From: Rafał Miłecki >> >> There are 3 separated controllers, one per USB /standard/. With PHY >> drivers in place they can be simply supported with generic drivers. >> >> Signed-off-by: Rafał Miłecki >> --- >> arch/arm/boot/dts/bcm5301x.dtsi | 33 ++++++++++++++++++++++++++++++++- >> 1 file changed, 32 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi >> index f09a2bb..bfc98d19 100644 >> --- a/arch/arm/boot/dts/bcm5301x.dtsi >> +++ b/arch/arm/boot/dts/bcm5301x.dtsi >> @@ -248,8 +248,26 @@ >> >> #address-cells = <1>; >> #size-cells = <1>; >> + ranges; >> >> - phys = <&usb2_phy>; >> + interrupt-parent = <&gic>; >> + >> + ohci: ohci@21000 { >> + #usb-cells = <0>; >> + >> + compatible = "generic-ohci"; >> + reg = <0x00022000 0x1000>; > > Your label ohci@21000 does not match the 'reg' at 0x22000. > >> + interrupts = ; >> + }; >> + >> + ehci: ehci@22000 { >> + #usb-cells = <0>; >> + >> + compatible = "generic-ehci"; >> + reg = <0x00021000 0x1000>; > > Looks like you got the label of ohci and ehci reversed? Nice catch, thanks! I'll fix it in V2 (just let me wait a day to see if there will be other comments). -- Rafał