Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754018AbcLFTps (ORCPT ); Tue, 6 Dec 2016 14:45:48 -0500 Received: from mail.kernel.org ([198.145.29.136]:40332 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751427AbcLFTpq (ORCPT ); Tue, 6 Dec 2016 14:45:46 -0500 Date: Tue, 6 Dec 2016 16:45:42 -0300 From: Arnaldo Carvalho de Melo To: Yannick Brosseau Cc: mingo@redhat.com, peterz@infradead.org, namhyung@kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH] perf tools: Explicitly document that --children is enabled by default Message-ID: <20161206194542.GD8257@kernel.org> References: <20161202160732.29058-1-scientist@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161202160732.29058-1-scientist@fb.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1957 Lines: 44 Em Fri, Dec 02, 2016 at 11:07:32AM -0500, Yannick Brosseau escreveu: > The fact that the --children option is enabled by default is buried deep > at the end of the help page, in the overhead calculation section. This > make it explicit right where the option is listed, following the same > way other default options are described Thanks, applied. - Arnaldo > Signed-off-by: Yannick Brosseau > --- > tools/perf/Documentation/perf-report.txt | 3 ++- > tools/perf/Documentation/perf-top.txt | 1 + > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/Documentation/perf-report.txt b/tools/perf/Documentation/perf-report.txt > index 2d17462..aaa8011 100644 > --- a/tools/perf/Documentation/perf-report.txt > +++ b/tools/perf/Documentation/perf-report.txt > @@ -239,7 +239,8 @@ OPTIONS > Accumulate callchain of children to parent entry so that then can > show up in the output. The output will have a new "Children" column > and will be sorted on the data. It requires callchains are recorded. > - See the `overhead calculation' section for more details. > + See the `overhead calculation' section for more details. Enabled by > + default, disable with --no-children. > > --max-stack:: > Set the stack depth limit when parsing the callchain, anything > diff --git a/tools/perf/Documentation/perf-top.txt b/tools/perf/Documentation/perf-top.txt > index 91d638d..e71d638 100644 > --- a/tools/perf/Documentation/perf-top.txt > +++ b/tools/perf/Documentation/perf-top.txt > @@ -170,6 +170,7 @@ Default is to monitor all CPUS. > show up in the output. The output will have a new "Children" column > and will be sorted on the data. It requires -g/--call-graph option > enabled. See the `overhead calculation' section for more details. > + Enabled by default, disable with --no-children. > > --max-stack:: > Set the stack depth limit when parsing the callchain, anything > -- > 2.10.2