Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752720AbcLFUGb (ORCPT ); Tue, 6 Dec 2016 15:06:31 -0500 Received: from mail-pg0-f42.google.com ([74.125.83.42]:36824 "EHLO mail-pg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751799AbcLFUG2 (ORCPT ); Tue, 6 Dec 2016 15:06:28 -0500 Date: Tue, 6 Dec 2016 15:06:21 -0500 From: Jon Mason To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Florian Fainelli , Arnd Bergmann , Rob Herring , Mark Rutland , Russell King , Hauke Mehrtens , bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH 4/5] ARM: BCM5301X: Specify all RAM by including extra block Message-ID: <20161206200621.GB2768@broadcom.com> References: <20161206171714.22738-1-zajec5@gmail.com> <20161206171714.22738-4-zajec5@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20161206171714.22738-4-zajec5@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 7971 Lines: 248 On Tue, Dec 06, 2016 at 06:17:13PM +0100, Rafał Miłecki wrote: > From: Rafał Miłecki > > So far we were specifying only the first block which is always limited > up to 128 MiB. There are many devices with 256 MiB and few with 512 MiB. Assuming that NS is like NSP (and I'm pretty sure it is), there are 2 ways to access the first 128M of RAM, a proxy starting at address 0 and the real address. I think you are splitting RAM by accessing it both ways, when you really should just be accessing it at the real address. Thanks, Jon > > Signed-off-by: Rafał Miłecki > --- > arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dts | 3 ++- > arch/arm/boot/dts/bcm4708-asus-rt-ac68u.dts | 3 ++- > arch/arm/boot/dts/bcm4708-buffalo-wzr-1750dhp.dts | 3 ++- > arch/arm/boot/dts/bcm4708-netgear-r6250.dts | 3 ++- > arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts | 3 ++- > arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts | 3 ++- > arch/arm/boot/dts/bcm47081-asus-rt-n18u.dts | 3 ++- > arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dts | 3 ++- > arch/arm/boot/dts/bcm47081-buffalo-wzr-900dhp.dts | 3 ++- > arch/arm/boot/dts/bcm4709-asus-rt-ac87u.dts | 3 ++- > arch/arm/boot/dts/bcm4709-buffalo-wxr-1900dhp.dts | 3 ++- > arch/arm/boot/dts/bcm4709-netgear-r7000.dts | 3 ++- > arch/arm/boot/dts/bcm4709-netgear-r8000.dts | 3 ++- > arch/arm/boot/dts/bcm47094-dlink-dir-885l.dts | 3 ++- > arch/arm/boot/dts/bcm47094-netgear-r8500.dts | 3 ++- > 15 files changed, 30 insertions(+), 15 deletions(-) > > diff --git a/arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dts b/arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dts > index 112a5a8..d241cee 100644 > --- a/arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dts > +++ b/arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dts > @@ -21,7 +21,8 @@ > }; > > memory { > - reg = <0x00000000 0x08000000>; > + reg = <0x00000000 0x08000000 > + 0x88000000 0x08000000>; > }; > > leds { > diff --git a/arch/arm/boot/dts/bcm4708-asus-rt-ac68u.dts b/arch/arm/boot/dts/bcm4708-asus-rt-ac68u.dts > index 3600f56..b0e6204 100644 > --- a/arch/arm/boot/dts/bcm4708-asus-rt-ac68u.dts > +++ b/arch/arm/boot/dts/bcm4708-asus-rt-ac68u.dts > @@ -21,7 +21,8 @@ > }; > > memory { > - reg = <0x00000000 0x08000000>; > + reg = <0x00000000 0x08000000 > + 0x88000000 0x08000000>; > }; > > leds { > diff --git a/arch/arm/boot/dts/bcm4708-buffalo-wzr-1750dhp.dts b/arch/arm/boot/dts/bcm4708-buffalo-wzr-1750dhp.dts > index d49afec0..c9ba6b9 100644 > --- a/arch/arm/boot/dts/bcm4708-buffalo-wzr-1750dhp.dts > +++ b/arch/arm/boot/dts/bcm4708-buffalo-wzr-1750dhp.dts > @@ -21,7 +21,8 @@ > }; > > memory { > - reg = <0x00000000 0x08000000>; > + reg = <0x00000000 0x08000000 > + 0x88000000 0x18000000>; > }; > > spi { > diff --git a/arch/arm/boot/dts/bcm4708-netgear-r6250.dts b/arch/arm/boot/dts/bcm4708-netgear-r6250.dts > index 8519548..b9f66c0 100644 > --- a/arch/arm/boot/dts/bcm4708-netgear-r6250.dts > +++ b/arch/arm/boot/dts/bcm4708-netgear-r6250.dts > @@ -21,7 +21,8 @@ > }; > > memory { > - reg = <0x00000000 0x08000000>; > + reg = <0x00000000 0x08000000 > + 0x88000000 0x08000000>; > }; > > leds { > diff --git a/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts b/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts > index 6229ef2..ae0199f 100644 > --- a/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts > +++ b/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts > @@ -21,7 +21,8 @@ > }; > > memory { > - reg = <0x00000000 0x08000000>; > + reg = <0x00000000 0x08000000 > + 0x88000000 0x08000000>; > }; > > leds { > diff --git a/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts b/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts > index 74cfcd3..36b628b1 100644 > --- a/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts > +++ b/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts > @@ -21,7 +21,8 @@ > }; > > memory { > - reg = <0x00000000 0x08000000>; > + reg = <0x00000000 0x08000000 > + 0x88000000 0x08000000>; > }; > > leds { > diff --git a/arch/arm/boot/dts/bcm47081-asus-rt-n18u.dts b/arch/arm/boot/dts/bcm47081-asus-rt-n18u.dts > index 71b98cf..db8608b 100644 > --- a/arch/arm/boot/dts/bcm47081-asus-rt-n18u.dts > +++ b/arch/arm/boot/dts/bcm47081-asus-rt-n18u.dts > @@ -21,7 +21,8 @@ > }; > > memory { > - reg = <0x00000000 0x08000000>; > + reg = <0x00000000 0x08000000 > + 0x88000000 0x08000000>; > }; > > leds { > diff --git a/arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dts b/arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dts > index 2922536..d51586d 100644 > --- a/arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dts > +++ b/arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dts > @@ -21,7 +21,8 @@ > }; > > memory { > - reg = <0x00000000 0x08000000>; > + reg = <0x00000000 0x08000000 > + 0x88000000 0x08000000>; > }; > > spi { > diff --git a/arch/arm/boot/dts/bcm47081-buffalo-wzr-900dhp.dts b/arch/arm/boot/dts/bcm47081-buffalo-wzr-900dhp.dts > index 184fd92..de041b8 100644 > --- a/arch/arm/boot/dts/bcm47081-buffalo-wzr-900dhp.dts > +++ b/arch/arm/boot/dts/bcm47081-buffalo-wzr-900dhp.dts > @@ -21,7 +21,8 @@ > }; > > memory { > - reg = <0x00000000 0x08000000>; > + reg = <0x00000000 0x08000000 > + 0x88000000 0x08000000>; > }; > > gpio-keys { > diff --git a/arch/arm/boot/dts/bcm4709-asus-rt-ac87u.dts b/arch/arm/boot/dts/bcm4709-asus-rt-ac87u.dts > index eac0f52..eaca687 100644 > --- a/arch/arm/boot/dts/bcm4709-asus-rt-ac87u.dts > +++ b/arch/arm/boot/dts/bcm4709-asus-rt-ac87u.dts > @@ -21,7 +21,8 @@ > }; > > memory { > - reg = <0x00000000 0x08000000>; > + reg = <0x00000000 0x08000000 > + 0x88000000 0x08000000>; > }; > > leds { > diff --git a/arch/arm/boot/dts/bcm4709-buffalo-wxr-1900dhp.dts b/arch/arm/boot/dts/bcm4709-buffalo-wxr-1900dhp.dts > index aab39c9..b32957c 100644 > --- a/arch/arm/boot/dts/bcm4709-buffalo-wxr-1900dhp.dts > +++ b/arch/arm/boot/dts/bcm4709-buffalo-wxr-1900dhp.dts > @@ -21,7 +21,8 @@ > }; > > memory { > - reg = <0x00000000 0x08000000>; > + reg = <0x00000000 0x08000000 > + 0x88000000 0x18000000>; > }; > > leds { > diff --git a/arch/arm/boot/dts/bcm4709-netgear-r7000.dts b/arch/arm/boot/dts/bcm4709-netgear-r7000.dts > index 7ab1176..f459a98 100644 > --- a/arch/arm/boot/dts/bcm4709-netgear-r7000.dts > +++ b/arch/arm/boot/dts/bcm4709-netgear-r7000.dts > @@ -21,7 +21,8 @@ > }; > > memory { > - reg = <0x00000000 0x08000000>; > + reg = <0x00000000 0x08000000 > + 0x88000000 0x08000000>; > }; > > leds { > diff --git a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts > index 56d38a3..cd13534 100644 > --- a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts > +++ b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts > @@ -21,7 +21,8 @@ > }; > > memory { > - reg = <0x00000000 0x08000000>; > + reg = <0x00000000 0x08000000 > + 0x88000000 0x08000000>; > }; > > leds { > diff --git a/arch/arm/boot/dts/bcm47094-dlink-dir-885l.dts b/arch/arm/boot/dts/bcm47094-dlink-dir-885l.dts > index 7fb9270..64ded76 100644 > --- a/arch/arm/boot/dts/bcm47094-dlink-dir-885l.dts > +++ b/arch/arm/boot/dts/bcm47094-dlink-dir-885l.dts > @@ -21,7 +21,8 @@ > }; > > memory { > - reg = <0x00000000 0x08000000>; > + reg = <0x00000000 0x08000000 > + 0x88000000 0x08000000>; > }; > > nand: nand@18028000 { > diff --git a/arch/arm/boot/dts/bcm47094-netgear-r8500.dts b/arch/arm/boot/dts/bcm47094-netgear-r8500.dts > index 7ecd57c..600795e 100644 > --- a/arch/arm/boot/dts/bcm47094-netgear-r8500.dts > +++ b/arch/arm/boot/dts/bcm47094-netgear-r8500.dts > @@ -18,7 +18,8 @@ > }; > > memory { > - reg = <0x00000000 0x08000000>; > + reg = <0x00000000 0x08000000 > + 0x88000000 0x18000000>; > }; > > leds { > -- > 2.10.1 >