Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752265AbcLFVZQ (ORCPT ); Tue, 6 Dec 2016 16:25:16 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:40718 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751725AbcLFVZK (ORCPT ); Tue, 6 Dec 2016 16:25:10 -0500 Date: Tue, 6 Dec 2016 13:25:38 -0800 From: Andrew Morton To: Matthew Wilcox Cc: Matthew Wilcox , "linux-kernel@vger.kernel.org" , "Konstantin Khlebnikov" , Ross Zwisler , Matthew Wilcox , "linux-mm@kvack.org" , "linux-fsdevel@vger.kernel.org" , "Kirill A . Shutemov" , Matthew Wilcox Subject: Re: [PATCH v3 33/33] Reimplement IDR and IDA using the radix tree Message-Id: <20161206132538.e474083ae851c7284bb89b2a@linux-foundation.org> In-Reply-To: References: <1480369871-5271-1-git-send-email-mawilcox@linuxonhyperv.com> <1480369871-5271-34-git-send-email-mawilcox@linuxonhyperv.com> <20161206124453.3d3ce26a1526fedd70988ab8@linux-foundation.org> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 890 Lines: 17 On Tue, 6 Dec 2016 21:17:52 +0000 Matthew Wilcox wrote: > From: Andrew Morton [mailto:akpm@linux-foundation.org] > > On Mon, 28 Nov 2016 13:50:37 -0800 Matthew Wilcox > > wrote: > > > include/linux/idr.h | 132 ++-- > > > include/linux/radix-tree.h | 5 +- > > > init/main.c | 3 +- > > > lib/idr.c | 1078 ------------------------------- > > > lib/radix-tree.c | 632 ++++++++++++++++-- > > > > hm. It's just a cosmetic issue, but perhaps the idr > > wrappers-around-radix-tree code should be in a different .c file. > > I can put some of them back into idr.c -- there's a couple of routines left in there still, so adding some more won't hurt. OK. Sometime. Let's see how this lot pans out as-is for now?