From: Matthew Wilcox <mawilcox@microsoft.com>
To: Andrew Morton <akpm@linux-foundation.org>,
        Matthew Wilcox <mawilcox@linuxonhyperv.com>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Konstantin Khlebnikov" <koct9i@gmail.com>,
        Ross Zwisler <ross.zwisler@linux.intel.com>,
        Matthew Wilcox <willy@linux.intel.com>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        Matthew Wilcox <willy@infradead.org>
Subject: RE: [PATCH v3 33/33] Reimplement IDR and IDA using the radix tree
Thread-Topic: [PATCH v3 33/33] Reimplement IDR and IDA using the radix tree
Thread-Index: AQHSUAGudvom4Ajtc0SwNJDbsXoPXqD7a6ew
Date: Tue, 6 Dec 2016 21:17:52 +0000
Message-ID: <CY1PR21MB0071D603E8B6F6A7F820492BCB820@CY1PR21MB0071.namprd21.prod.outlook.com>
References: <1480369871-5271-1-git-send-email-mawilcox@linuxonhyperv.com>
        <1480369871-5271-34-git-send-email-mawilcox@linuxonhyperv.com>
 <20161206124453.3d3ce26a1526fedd70988ab8@linux-foundation.org>
In-Reply-To: <20161206124453.3d3ce26a1526fedd70988ab8@linux-foundation.org>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Dec 2016 21:17:52.1637
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR21MB0070
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id uB6Ls03R004125
Content-Length: 1325
Lines: 30

From: Andrew Morton [mailto:akpm@linux-foundation.org]
> On Mon, 28 Nov 2016 13:50:37 -0800 Matthew Wilcox
> <mawilcox@linuxonhyperv.com> wrote:
> >  include/linux/idr.h                     |  132 ++--
> >  include/linux/radix-tree.h              |    5 +-
> >  init/main.c                             |    3 +-
> >  lib/idr.c                               | 1078 -------------------------------
> >  lib/radix-tree.c                        |  632 ++++++++++++++++--
> 
> hm.  It's just a cosmetic issue, but perhaps the idr
> wrappers-around-radix-tree code should be in a different .c file.

I can put some of them back into idr.c -- there's a couple of routines left in there still, so adding some more won't hurt.

> Before:
> 
> akpm3:/usr/src/25> size lib/idr.o lib/radix-tree.o
>    text    data     bss     dec     hex filename
>    6566      89      16    6671    1a0f lib/idr.o
>   11811     117       8   11936    2ea0 lib/radix-tree.o
> 
> After:
> 
>    text    data     bss     dec     hex filename
>   14151     118       8   14277    37c5 lib/radix-tree.o
> 
> 
> So 4500 bytes saved.  Decent.

Not bad.  0day has been sending me email telling me that I saved something more like 1500 bytes, but that's on a minimal config.  (also a couple of routines stayed in idr.c, so you're overstating how much I saved)