Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752323AbcLFWNg (ORCPT ); Tue, 6 Dec 2016 17:13:36 -0500 Received: from frisell.zx2c4.com ([192.95.5.64]:33013 "EHLO frisell.zx2c4.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751327AbcLFWNf (ORCPT ); Tue, 6 Dec 2016 17:13:35 -0500 MIME-Version: 1.0 In-Reply-To: <1480685957-18809-2-git-send-email-matt.redfearn@imgtec.com> References: <1480685957-18809-1-git-send-email-matt.redfearn@imgtec.com> <1480685957-18809-2-git-send-email-matt.redfearn@imgtec.com> From: "Jason A. Donenfeld" Date: Tue, 6 Dec 2016 23:13:30 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/5] MIPS: Introduce irq_stack To: Matt Redfearn Cc: Ralf Baechle , linux-mips@linux-mips.org, Thomas Gleixner , Paolo Bonzini , Chris Metcalf , Petr Mladek , LKML , James Hogan , Paul Burton , Aaron Tomlin , Andrew Morton Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 228 Lines: 5 On Fri, Dec 2, 2016 at 2:39 PM, Matt Redfearn wrote: > +void *irq_stack[NR_CPUS]; I'm curious why you implemented it this way rather than using DEFINE_PER_CPU and the related percpu helper functions.