Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752984AbcLFWqZ (ORCPT ); Tue, 6 Dec 2016 17:46:25 -0500 Received: from mail-db5eur01on0085.outbound.protection.outlook.com ([104.47.2.85]:51520 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752186AbcLFWqX (ORCPT ); Tue, 6 Dec 2016 17:46:23 -0500 From: Stuart Yoder To: Greg KH CC: Ruxandra Ioana Radulescu , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" , "agraf@suse.de" , "arnd@arndb.de" , "Alexandru Marginean" , Bogdan Hamciuc , Roy Pledge , Laurentiu Tudor Subject: RE: [PATCH 7/8] staging: fsl-dpaa2/eth: Add TODO file Thread-Topic: [PATCH 7/8] staging: fsl-dpaa2/eth: Add TODO file Thread-Index: AQHST6P8gLAcyQr7sk6cziYpfvtUZaD6rywAgAACWoCAAAPcAIAAJqoQgABYp4CAAANakA== Date: Tue, 6 Dec 2016 18:10:38 +0000 Message-ID: References: <20161206093442.11362-1-ruxandra.radulescu@nxp.com> <20161206093442.11362-8-ruxandra.radulescu@nxp.com> <20161206095800.GA4247@kroah.com> <20161206102014.GA7899@kroah.com> <20161206175555.GB15607@kroah.com> In-Reply-To: <20161206175555.GB15607@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=stuart.yoder@nxp.com; x-originating-ip: [192.88.158.246] x-microsoft-exchange-diagnostics: 1;VI1PR0401MB2655;7:wPxxCDhKMujIqzKag+KI6ZZLZ0kNDlVdLwyiY2mTkwOLikJG6PTWQFPS3wCFxVABWSnjlMG5pekgDDN5vYJuCg44jUH69MCJ2kUr8ALphKpoFB9I7E5ZF3muP6eHUlqD5gVDVpx0wa5UrNk2VA+wHi6yyYVSTaOAAHQeYidRXHKY5mXh+yObcCujwAxrMWlke6amql+eLBg1o5GlEJk3DBrwKIPmObNriCBPTucY6Asa51giZfCJCWmqAJrkw0LQFlQ1YDvpZkqXOnlgPU4hiqbk+MZ2Gw3r+vldLria4+HRT8X9VHpXaMh3p49KBIdRMtyDOLLdrDdb7H0/6asSrguTwkC+RAQX8mJ91YhZZo8= x-forefront-antispam-report: SFV:SKI;SCL:-1SFV:NSPM;SFS:(10009020)(6009001)(7916002)(377454003)(24454002)(199003)(189002)(13464003)(86362001)(33656002)(81156014)(66066001)(39860400001)(106356001)(110136003)(105586002)(2906002)(9686002)(77096006)(3280700002)(39410400001)(54356999)(39840400001)(38730400001)(106116001)(229853002)(6506006)(50986999)(189998001)(76176999)(68736007)(8936002)(305945005)(4326007)(8676002)(6916009)(6116002)(76576001)(92566002)(93886004)(7696004)(39450400002)(5660300001)(2900100001)(122556002)(74316002)(7846002)(39850400001)(97736004)(3660700001)(3846002)(102836003)(101416001)(7736002)(2950100002)(81166006);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0401MB2655;H:VI1PR0401MB2638.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; x-ms-office365-filtering-correlation-id: bfd04d3f-3a54-45d9-46b9-08d41e032ecf x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:VI1PR0401MB2655; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(185117386973197); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026)(6041248)(20161123564025)(20161123555025)(20161123560025)(20161123562025)(6047074)(6072148);SRVR:VI1PR0401MB2655;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0401MB2655; x-forefront-prvs: 01480965DA spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Dec 2016 18:10:38.2071 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2655 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uB6MkcJq020396 Content-Length: 5101 Lines: 106 > -----Original Message----- > From: Greg KH [mailto:gregkh@linuxfoundation.org] > Sent: Tuesday, December 06, 2016 11:56 AM > To: Stuart Yoder > Cc: Ruxandra Ioana Radulescu ; devel@driverdev.osuosl.org; linux- > kernel@vger.kernel.org; agraf@suse.de; arnd@arndb.de; Alexandru Marginean ; > Bogdan Hamciuc ; Roy Pledge ; Laurentiu Tudor > > Subject: Re: [PATCH 7/8] staging: fsl-dpaa2/eth: Add TODO file > > On Tue, Dec 06, 2016 at 12:59:59PM +0000, Stuart Yoder wrote: > > > > > > > -----Original Message----- > > > From: Greg KH [mailto:gregkh@linuxfoundation.org] > > > Sent: Tuesday, December 06, 2016 4:20 AM > > > To: Ruxandra Ioana Radulescu > > > Cc: devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org; agraf@suse.de; arnd@arndb.de; > Alexandru > > > Marginean ; Bogdan Hamciuc ; Stuart Yoder > > > ; Roy Pledge ; Laurentiu Tudor > > > Subject: Re: [PATCH 7/8] staging: fsl-dpaa2/eth: Add TODO file > > > > > > On Tue, Dec 06, 2016 at 10:06:25AM +0000, Ruxandra Ioana Radulescu wrote: > > > > > -----Original Message----- > > > > > From: Greg KH [mailto:gregkh@linuxfoundation.org] > > > > > Sent: Tuesday, December 06, 2016 11:58 AM > > > > > To: Ruxandra Ioana Radulescu > > > > > Cc: devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org; > > > > > agraf@suse.de; arnd@arndb.de; Alexandru Marginean > > > > > ; Bogdan Hamciuc > > > > > ; Stuart Yoder ; Roy > > > > > Pledge ; Laurentiu Tudor > > > > > > > > > > Subject: Re: [PATCH 7/8] staging: fsl-dpaa2/eth: Add TODO file > > > > > > > > > > On Tue, Dec 06, 2016 at 03:34:41AM -0600, Ioana Radulescu wrote: > > > > > > Add a list of TODO items for the Ethernet driver > > > > > > > > > > > > Signed-off-by: Ioana Radulescu > > > > > > --- > > > > > > drivers/staging/fsl-dpaa2/ethernet/TODO | 9 +++++++++ > > > > > > 1 files changed, 9 insertions(+), 0 deletions(-) > > > > > > create mode 100644 drivers/staging/fsl-dpaa2/ethernet/TODO > > > > > > > > > > > > diff --git a/drivers/staging/fsl-dpaa2/ethernet/TODO b/drivers/staging/fsl- > > > > > dpaa2/ethernet/TODO > > > > > > new file mode 100644 > > > > > > index 0000000..833265b > > > > > > --- /dev/null > > > > > > +++ b/drivers/staging/fsl-dpaa2/ethernet/TODO > > > > > > @@ -0,0 +1,9 @@ > > > > > > +* Add a DPAA2 MAC kernel driver in order to allow PHY management; > > > > > currently > > > > > > + the DPMAC objects and their link to DPNIs are handled by MC internally > > > > > > + and all PHYs are seen as fixed-link > > > > > > +* add more debug support: decide how to expose detailed debug > > > > > statistics, > > > > > > + add ingress error queue support > > > > > > +* MC firmware uprev; the DPAA2 objects used by the Ethernet driver > > > > > need to > > > > > > + be kept in sync with binary interface changes in MC > > > > > > +* refine README file > > > > > > +* cleanup > > > > > > > > > > These seem like very minor things, why not just spend a week and do this > > > > > work and get it merged to the "correct" portion of the kernel tree? Why > > > > > does this have to go into staging? > > > > > > > > Actually the first bullet is not minor at all and requires some design > > > > choices that we aren't yet completely clear with, and which in turn may > > > > affect parts of the Ethernet driver. We figured it would be best to try > > > > adding this in staging first (and also provide this way an example of using > > > > the fsl-mc bus and dpio driver) than wait until all MAC development > > > > questions are ironed-out. > > > > > > Ok, that makes sense. > > > > > > > I can remove the other bullets from the TODO list if you think they're > > > > not worth mentioning. > > > > > > No, they should be mentioned, I just didn't think they are all that much > > > work, and if you didn't have major things needed to get done, you could > > > just knock it all out in a week of local development. > > > > > > I'll look into taking this into the tree later today... > > > > Note, as mentioned in the cover letter, in it's current form this patch > > series is based on the series: > > [PATCH v3 0/9] staging: fsl-mc: move bus driver out of staging, add dpio > > > > ...which means that it won't build or run without that series being > > applied first, due to header file dependencies. It also functionally > > depends on the DPIO driver. So we need the dpio driver merged first. > > > > Is moving the fsl-mc bus driver out of staging a possibility now? > > I'm ok with it, but I really haven't looked at the patches in a while, I > keep seeing others have problems with it. Want me to review it now? Yes, would like that very much. Thanks, Stuart