Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753100AbcLFWrG (ORCPT ); Tue, 6 Dec 2016 17:47:06 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:34503 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751786AbcLFWrE (ORCPT ); Tue, 6 Dec 2016 17:47:04 -0500 Subject: Re: [PATCH 1/3] ARM: Define KERNEL_START and KERNEL_END To: Chris Brandt , "linux-arm-kernel@lists.infradead.org" References: <1480445729-27130-1-git-send-email-labbott@redhat.com> <20161206195312.22354-1-f.fainelli@gmail.com> <20161206195312.22354-2-f.fainelli@gmail.com> Cc: "linux@armlinux.org.uk" , "nicolas.pitre@linaro.org" , "panand@redhat.com" , "arnd@arndb.de" , "jonathan.austin@arm.com" , "pawel.moll@arm.com" , "vladimir.murzin@arm.com" , "mark.rutland@arm.com" , "ard.biesheuvel@linaro.org" , "keescook@chromium.org" , "matt@codeblueprint.co.uk" , "labbott@fedoraproject.org" , "kirill.shutemov@linux.intel.com" , "ben@decadent.org.uk" , "js07.lee@samsung.com" , "stefan@agner.ch" , "linux-kernel@vger.kernel.org" From: Florian Fainelli Message-ID: Date: Tue, 6 Dec 2016 14:47:01 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1058 Lines: 27 On 12/06/2016 02:43 PM, Chris Brandt wrote: > On 12/6/2016, Florian Fainelli wrote: >> diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c >> index 4001dd15818d..18ef688a796e 100644 >> --- a/arch/arm/mm/mmu.c >> +++ b/arch/arm/mm/mmu.c >> @@ -1437,12 +1437,8 @@ static void __init kmap_init(void) >> static void __init map_lowmem(void) >> { >> struct memblock_region *reg; >> -#ifdef CONFIG_XIP_KERNEL >> - phys_addr_t kernel_x_start = round_down(__pa(_sdata), SECTION_SIZE); >> -#else >> - phys_addr_t kernel_x_start = round_down(__pa(_stext), SECTION_SIZE); >> -#endif >> - phys_addr_t kernel_x_end = round_up(__pa(__init_end), SECTION_SIZE); >> + phys_addr_t kernel_x_start = round_down(__pa(KERNEL_START), >> SECTION_SIZE); >> + phys_addr_t kernel_x_end = round_down(__pa(_end), SECTION_SIZE); > > Why are you changing the end of executable kernel (hence the 'x' in > kernel_x_end) from __init_end to _end which basically maps the entire > kernel image including text and data? That's a typo, was not intentional thanks for spotting it. -- Florian