Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752352AbcLGAKc (ORCPT ); Tue, 6 Dec 2016 19:10:32 -0500 Received: from mail-io0-f196.google.com ([209.85.223.196]:35548 "EHLO mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751721AbcLGAKa (ORCPT ); Tue, 6 Dec 2016 19:10:30 -0500 MIME-Version: 1.0 In-Reply-To: References: From: Cong Wang Date: Tue, 6 Dec 2016 16:10:08 -0800 Message-ID: Subject: Re: [PATCH]net:sched:release lock before tcf_dump_walker() normal return to avoid deadlock To: Jamal Hadi Salim Cc: Feng Deng , "David S. Miller" , Linux Kernel Network Developers , LKML , feng.deng@cortina-access.com, Roman Mashak Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 454 Lines: 15 On Tue, Dec 6, 2016 at 5:50 AM, Jamal Hadi Salim wrote: > On 16-12-06 12:36 AM, Feng Deng wrote: >> >> From: Feng Deng >> >> release lock before tcf_dump_walker() normal return to avoid deadlock >> > > /Scratching my head. > > I am probably missing something obvious. > What are the condition under which this deadlock will happen? > Do you have a testcase we can try? I don't even see a patch (tried Google too).