Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752833AbcLGBfF (ORCPT ); Tue, 6 Dec 2016 20:35:05 -0500 Received: from conssluserg-01.nifty.com ([210.131.2.80]:17736 "EHLO conssluserg-01.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752671AbcLGBfC (ORCPT ); Tue, 6 Dec 2016 20:35:02 -0500 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-01.nifty.com uB71Ysdk015386 X-Nifty-SrcIP: [209.85.216.180] MIME-Version: 1.0 In-Reply-To: <20161206231642.GA4388@codeaurora.org> References: <1480725436-9628-1-git-send-email-vlee@freedesktop.org> <20161206231642.GA4388@codeaurora.org> From: Masahiro Yamada Date: Wed, 7 Dec 2016 10:34:53 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] clk: uniphier: Fix build with gcc-4.4. To: Stephen Boyd Cc: Michael Turquette , Linux Kernel Mailing List , Vinson Lee , Andrew Morton , linux-clk , linux-arm-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uB71Z99s024183 Content-Length: 1218 Lines: 46 Hi Stephen, 2016-12-07 8:16 GMT+09:00 Stephen Boyd : > On 12/03, Masahiro Yamada wrote: >> Hi Vinson, >> >> 2016-12-03 9:37 GMT+09:00 Vinson Lee : >> > gcc-4.4 has issues with anonymous unions in initializers. >> > >> > CC drivers/clk/uniphier/clk-uniphier-sys.o >> > drivers/clk/uniphier/clk-uniphier-sys.c:45: error: unknown field ‘factor’ specified in initializer >> > >> > Fixes: 1574d5722636 ("clk: uniphier: remove unneeded member name for union") >> > Signed-off-by: Vinson Lee >> >> >> This driver has COMPILE_TEST option, but kbuild test robot >> did not mention about this. >> >> >> >> This is a bad way of fixing, I think. >> (what if a new member is inserted before the union in the future?) >> >> Rather, please revert the bad commit. >> > > Reverting on top of clk-next will cause build failures though. > Can you resend the patch series without this first patch please? > I'll apply them then. > > I'll go drop all three patches and wreck Andrew's merge of this > patch to -mm. I dropped the first one and v3 (for the last two) is on the ML now. Thanks a lot for taking care of this! -- Best Regards Masahiro Yamada