Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932233AbcLGEOK (ORCPT ); Tue, 6 Dec 2016 23:14:10 -0500 Received: from mail-oi0-f53.google.com ([209.85.218.53]:33144 "EHLO mail-oi0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753743AbcLGEN4 (ORCPT ); Tue, 6 Dec 2016 23:13:56 -0500 MIME-Version: 1.0 In-Reply-To: <584787FF.6030002@samsung.com> References: <1481011582-7162-1-git-send-email-john.stultz@linaro.org> <1481011582-7162-2-git-send-email-john.stultz@linaro.org> <584787FF.6030002@samsung.com> From: John Stultz Date: Tue, 6 Dec 2016 20:13:54 -0800 Message-ID: Subject: Re: [RFC][PATCH 1/3 v2] usb: dwc2: Add extcon support to dwc2 driver To: Chanwoo Choi Cc: lkml , Wei Xu , Guodong Xu , Amit Pundir , Rob Herring , John Youn , Douglas Anderson , Chen Yu , Kishon Vijay Abraham I , Felipe Balbi , Greg Kroah-Hartman , Linux USB List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 557 Lines: 15 On Tue, Dec 6, 2016 at 7:54 PM, Chanwoo Choi wrote: > Hi John, > > I give a some guide for extcon API. > This patch uses the deprecated extcon API (extcon_get_cable_state_). > So, I recommend that you better to use following extcon API: > - extcon_get_cable_state_() -> extcon_get_state() > - extcon_register_notifier() -> devm_extcon_register_notifier() Many thanks for the pointers! I really appreciate it! I'll rework the driver accordingly (if JohnY doesn't conclude that the extcon support here is unnecessary). thanks -john