MIME-Version: 1.0
In-Reply-To: <584787FF.6030002@samsung.com>
References: <1481011582-7162-1-git-send-email-john.stultz@linaro.org>
 <CGME20161206080833epcas4p1cb6159fa2eb82cddda8266c84b5bb0d5@epcas4p1.samsung.com>
 <1481011582-7162-2-git-send-email-john.stultz@linaro.org> <584787FF.6030002@samsung.com>
From: John Stultz <john.stultz@linaro.org>
Date: Tue, 6 Dec 2016 20:13:54 -0800
Message-ID: <CALAqxLWRpiCw7xoe6-8wbn8hMrXBjhbUCfA3rh8=YhkAugzHYA@mail.gmail.com>
Subject: Re: [RFC][PATCH 1/3 v2] usb: dwc2: Add extcon support to dwc2 driver
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: lkml <linux-kernel@vger.kernel.org>, Wei Xu <xuwei5@hisilicon.com>,
        Guodong Xu <guodong.xu@linaro.org>,
        Amit Pundir <amit.pundir@linaro.org>, Rob Herring <robh+dt@kernel.org>,
        John Youn <johnyoun@synopsys.com>,
        Douglas Anderson <dianders@chromium.org>,
        Chen Yu <chenyu56@huawei.com>, Kishon Vijay Abraham I <kishon@ti.com>,
        Felipe Balbi <felipe.balbi@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Linux USB List <linux-usb@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 557
Lines: 15

On Tue, Dec 6, 2016 at 7:54 PM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
> Hi John,
>
> I give a some guide for extcon API.
> This patch uses the deprecated extcon API (extcon_get_cable_state_).
> So, I recommend that you better to use following extcon API:
> - extcon_get_cable_state_()  -> extcon_get_state()
> - extcon_register_notifier() -> devm_extcon_register_notifier()

Many thanks for the pointers! I really appreciate it! I'll rework the
driver accordingly (if JohnY doesn't conclude that the extcon support
here is unnecessary).

thanks
-john