Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752252AbcLGG6Y (ORCPT ); Wed, 7 Dec 2016 01:58:24 -0500 Received: from 001b2d01.pphosted.com ([148.163.156.1]:60497 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751092AbcLGG6X (ORCPT ); Wed, 7 Dec 2016 01:58:23 -0500 Subject: Re: [PATCH 3/3] powerpc: enable support for GCC plugins To: Emese Revfy References: <20161206062800.21800-1-andrew.donnellan@au1.ibm.com> <20161206062800.21800-3-andrew.donnellan@au1.ibm.com> <20161206222520.7fb37896488eff1b299eb3db@gmail.com> Cc: spender@grsecurity.net, keescook@chromium.org, linux-kbuild@vger.kernel.org, kernel-hardening@lists.openwall.com, linux-kernel@vger.kernel.org, mmarek@suse.com, pageexec@freemail.hu, linuxppc-dev@lists.ozlabs.org From: Andrew Donnellan Date: Wed, 7 Dec 2016 16:49:41 +1100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161206222520.7fb37896488eff1b299eb3db@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16120705-0040-0000-0000-000002D350CD X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16120705-0041-0000-0000-00000BD65B32 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-12-06_15:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1612070103 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1289 Lines: 33 On 07/12/16 08:25, Emese Revfy wrote: > What are these missing headers? Because if they aren't necessary then they can > be removed from gcc-common.h. There were missing headers on arm/arm64 and these > archs are supported. I think this version check is unnecessary because > gcc-plugin.sh also checks the missing headers. rs6000-cpus.def, included via tm.h - see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66840 I realise gcc-plugin.sh does detect this, but the point of the additional version check is to provide somewhat more helpful advice to the user. > What is the problem on gcc-4.5/gcc-4.6? On 4.6.4, c-family/c-common.h: /scratch/ajd/gcc-test-v2/kernel/scripts/gcc-plugins/gcc-common.h:60:31: fatal error: c-family/c-common.h: No such file or directory ajd@ka1:/scratch/ajd/tmp/cross/gcc-4.6.4-nolibc/powerpc64-linux$ find -name c-common.* ./lib/gcc/powerpc64-linux/4.6.4/plugin/include/c-common.h ./lib/gcc/powerpc64-linux/4.6.4/plugin/include/c-family/c-common.def Are we sure the version check in gcc-common.h:59 is correct, or is this just a peculiarity of my particular toolchain? I need to build another 4.5 toolchain, I'll try to do that this week. -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnellan@au1.ibm.com IBM Australia Limited