Date: Wed, 7 Dec 2016 10:02:19 +0100
From: Greg KH <gregkh@linuxfoundation.org>
To: Chris Bostic <christopher.lee.bostic@gmail.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk,
        sre@kernel.org, mturquette@baylibre.com, geert+renesas@glider.be,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Jeremy Kerr <jk@ozlabs.org>, joel@jms.id.au,
        linux-kernel@vger.kernel.org, andrew@aj.id.au, alistair@popple.id.au,
        benh@kernel.crashing.org, Chris Bostic <cbostic@us.ibm.com>
Subject: Re: [PATCH 08/16] drivers/fsi: Add crc4 helpers
Message-ID: <20161207090219.GA14742@kroah.com>
References: <1481076574-54711-1-git-send-email-christopher.lee.bostic@gmail.com>
 <1481076574-54711-2-git-send-email-christopher.lee.bostic@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1481076574-54711-2-git-send-email-christopher.lee.bostic@gmail.com>
User-Agent: Mutt/1.7.2 (2016-11-26)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 789
Lines: 23

On Tue, Dec 06, 2016 at 08:09:31PM -0600, Chris Bostic wrote:
> From: Jeremy Kerr <jk@ozlabs.org>
> 
> Add some helpers for the crc checks for the slave configuration table.
> This works 4-bits-at-a-time, using a simple table approach.
> 
> We will need this in the FSI core code, as well as any master
> implementations that need to calculate CRCs in software.
> 
> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
> Signed-off-by: Chris Bostic <cbostic@us.ibm.com>
> ---
>  drivers/fsi/fsi-core.c   | 21 +++++++++++++++++++++
>  drivers/fsi/fsi-master.h | 21 +++++++++++++++++++++
>  2 files changed, 42 insertions(+)

Why not just create lib/crc4.c with these functions, like the other crc
functions in the kernel?  Don't bury these in some random driver
subsystem please.

thanks,

greg k-h