Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752850AbcLGJhM (ORCPT ); Wed, 7 Dec 2016 04:37:12 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:43410 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752374AbcLGJhL (ORCPT ); Wed, 7 Dec 2016 04:37:11 -0500 Date: Wed, 7 Dec 2016 10:29:07 +0100 From: Greg KH To: Chris Bostic Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, sre@kernel.org, mturquette@baylibre.com, geert+renesas@glider.be, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jeremy Kerr , joel@jms.id.au, linux-kernel@vger.kernel.org, andrew@aj.id.au, alistair@popple.id.au, benh@kernel.crashing.org, Chris Bostic Subject: Re: [PATCH 11/16] drivers/fsi: Add device read/write/peek functions Message-ID: <20161207092907.GC14742@kroah.com> References: <1481076574-54711-1-git-send-email-christopher.lee.bostic@gmail.com> <1481076574-54711-4-git-send-email-christopher.lee.bostic@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1481076574-54711-4-git-send-email-christopher.lee.bostic@gmail.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1044 Lines: 34 On Tue, Dec 06, 2016 at 08:09:33PM -0600, Chris Bostic wrote: > diff --git a/include/linux/fsi.h b/include/linux/fsi.h > index efa55ba..66bce48 100644 > --- a/include/linux/fsi.h > +++ b/include/linux/fsi.h > @@ -27,6 +27,12 @@ struct fsi_device { > uint32_t size; > }; > > +extern int fsi_device_read(struct fsi_device *dev, uint32_t addr, > + void *val, size_t size); > +extern int fsi_device_write(struct fsi_device *dev, uint32_t addr, > + const void *val, size_t size); > +extern int fsi_device_peek(struct fsi_device *dev, void *val); > + > struct fsi_device_id { > u8 engine_type; > u8 version; > @@ -40,7 +46,6 @@ struct fsi_device_id { > #define FSI_DEVICE_VERSIONED(t, v) \ > .engine_type = (t), .version = (v), > > - > struct fsi_driver { > struct device_driver drv; > const struct fsi_device_id *id_table; Strange whitespace change here :) Not a real problem, I like the fact that you have broken this down into very logical pieces making it much easier to review, thanks so much for doing this. greg k-h