Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753091AbcLGKkh (ORCPT ); Wed, 7 Dec 2016 05:40:37 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:45178 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752190AbcLGKkg (ORCPT ); Wed, 7 Dec 2016 05:40:36 -0500 Date: Wed, 7 Dec 2016 11:40:43 +0100 From: Greg Kroah-Hartman To: Oleg Drokin Cc: devel@driverdev.osuosl.org, Andreas Dilger , James Simmons , Bhaktipriya Shridhar , Linux Kernel Mailing List , Lustre Development List Subject: Re: [PATCH] staging/lustre/osc: Revert erroneous list_for_each_entry_safe use Message-ID: <20161207104043.GA21689@kroah.com> References: <1481082828-1590398-1-git-send-email-green@linuxhacker.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1481082828-1590398-1-git-send-email-green@linuxhacker.ru> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1495 Lines: 32 On Tue, Dec 06, 2016 at 10:53:48PM -0500, Oleg Drokin wrote: > I have been having a lot of unexplainable crashes in osc_lru_shrink > lately that I could not see a good explanation for and then I found > this patch that slip under the radar somehow that incorrectly > converted while loop for lru list iteration into > list_for_each_entry_safe totally ignoring that in the body of > the loop we drop spinlocks guarding this list and move list entries > around. > Not sure why it was not showing up right away, perhaps some of the > more recent LRU changes committed caused some extra pressure on this > code that finally highlighted the breakage. > > Reverts: 8adddc36b1fc ("staging: lustre: osc: Use list_for_each_entry_safe") > CC: Bhaktipriya Shridhar > Signed-off-by: Oleg Drokin > --- > I also do not see this patch in any of the mailing lists I am subscribed to. > I wonder if there's a way to subscribe to those Greg's > "This is a note to let you know that I've just added the patch ...." > emails that concern Lustre to get them even if I am not on the CC list in > the patch itself? This came in from the Outreacy application process, which now requires that they cc: the maintainers to catch this type of issue. So you should have seen these types of patches this last round, the commit you reference was done before that change happened, sorry. This change should go to stable kernels, so I'll mark it that way. thanks, greg k-h