Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752647AbcLGLXC (ORCPT ); Wed, 7 Dec 2016 06:23:02 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:36260 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751900AbcLGLXA (ORCPT ); Wed, 7 Dec 2016 06:23:00 -0500 Date: Wed, 7 Dec 2016 14:14:24 +0300 From: Dan Carpenter To: Iyappan Subramanian Cc: Keyur Chudgar , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch] drivers: net: xgene: uninitialized variable in xgene_enet_free_pagepool() Message-ID: <20161207111424.GA5507@elgon.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 753 Lines: 20 We never set "slots" in this function. Fixes: a9380b0f7be8 ("drivers: net: xgene: Add support for Jumbo frame") Signed-off-by: Dan Carpenter --- I copied how slots gets set in xgene_enet_rx_frame(). Static analysis. Not tested. diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c index 6c7eea8b36af..884a334e82d0 100644 --- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c @@ -635,6 +635,7 @@ static void xgene_enet_free_pagepool(struct xgene_enet_desc_ring *buf_pool, return; dev = ndev_to_dev(buf_pool->ndev); + slots = buf_pool->slots - 1; head = buf_pool->head; for (i = 0; i < 4; i++) {