Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752524AbcLGLtb (ORCPT ); Wed, 7 Dec 2016 06:49:31 -0500 Received: from mail.kernel.org ([198.145.29.136]:42444 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751742AbcLGLt2 (ORCPT ); Wed, 7 Dec 2016 06:49:28 -0500 Date: Wed, 7 Dec 2016 19:48:16 +0800 From: Shawn Guo To: Baoyou Xie Cc: jun.nie@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, xie.baoyou@zte.com.cn, chen.chaokai@zte.com.cn, wang.qiang01@zte.com.cn Subject: Re: [PATCH] dt: bindings: zx: Add header for PM domains specifiers Message-ID: <20161207114814.GA17071@dragon> References: <1480983711-29955-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1480983711-29955-1-git-send-email-baoyou.xie@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1589 Lines: 53 On Tue, Dec 06, 2016 at 08:21:51AM +0800, Baoyou Xie wrote: > This patch adds header with values used for ZTE 2967 > SoC's power domain driver. > > Signed-off-by: Baoyou Xie > --- > include/dt-bindings/arm/zte_pm_domains.h | 23 +++++++++++++++++++++++ Considering that we are adding power domain drivers into drivers/soc/zte, it might be better to put the header into folder include/dt-bindings/soc/. > 1 file changed, 23 insertions(+) > create mode 100644 include/dt-bindings/arm/zte_pm_domains.h > > diff --git a/include/dt-bindings/arm/zte_pm_domains.h b/include/dt-bindings/arm/zte_pm_domains.h > new file mode 100644 > index 0000000..1485e8d > --- /dev/null > +++ b/include/dt-bindings/arm/zte_pm_domains.h > @@ -0,0 +1,23 @@ > +/* > + * Copyright (C) 2015 Linaro Ltd. > + * > + * Author: Baoyou Xie > + * License terms: GNU General Public License (GPL) version 2 > + */ > +#ifndef _DT_BINDINGS_ARM_ZTE_PM_DOMAINS_H > +#define _DT_BINDINGS_ARM_ZTE_PM_DOMAINS_H > + > +#define DM_ZX296718_SAPPU 0 > +#define DM_ZX296718_VDE 1 /*g1v6*/ > +#define DM_ZX296718_VCE 2 /*h1v6*/ > +#define DM_ZX296718_HDE 3 /*g2v2*/ The single line comment should be /* blabla */. Note there is space after and before *. Shawn > +#define DM_ZX296718_VIU 4 > +#define DM_ZX296718_USB20 5 > +#define DM_ZX296718_USB21 6 > +#define DM_ZX296718_USB30 7 > +#define DM_ZX296718_HSIC 8 > +#define DM_ZX296718_GMAC 9 > +#define DM_ZX296718_TS 10 > +#define DM_ZX296718_VOU 11 > + > +#endif /* _DT_BINDINGS_ARM_ZTE_PM_DOMAINS_H */ > -- > 2.7.4 >