Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752704AbcLGMQX (ORCPT ); Wed, 7 Dec 2016 07:16:23 -0500 Received: from fllnx210.ext.ti.com ([198.47.19.17]:41167 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751884AbcLGMQV (ORCPT ); Wed, 7 Dec 2016 07:16:21 -0500 Subject: Re: [PATCH 1/2] usb: dwc3: gadget: Fix full speed mode To: Felipe Balbi References: <1480416997-19757-1-git-send-email-rogerq@ti.com> <1480416997-19757-2-git-send-email-rogerq@ti.com> <87k2bmo662.fsf@linux.intel.com> CC: , From: Roger Quadros Message-ID: <4b44adf6-7569-71bf-b4c6-e811aeebfd1d@ti.com> Date: Wed, 7 Dec 2016 14:16:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 773 Lines: 29 Hi, On 29/11/16 14:28, Roger Quadros wrote: > Hi, > > On 29/11/16 13:51, Felipe Balbi wrote: >> >> Hi, >> >> Roger Quadros writes: >>> DCFG.DEVSPD == 0x3 is not valid and we need to set >>> DCFG.DEVSPD to 0x1 for full speed mode. >> >> seems like it has been made invalid somewhere between 1.73a and >> 2.60a. Can you figure it out from Documentation why and when it was made >> invalid? We might need revision checks here. >> > > I'll try to dig out more. I couldn't figure out more information on this. The changelogs in the TRMs don't capture this change and I don't have access to all TRM versions so I can't say which version it got changed and why. Can we please involve someone from Synopsis to provide this information? Thanks. cheers, -roger