Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752923AbcLGN3I (ORCPT ); Wed, 7 Dec 2016 08:29:08 -0500 Received: from mail-wj0-f176.google.com ([209.85.210.176]:35786 "EHLO mail-wj0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752564AbcLGN3E (ORCPT ); Wed, 7 Dec 2016 08:29:04 -0500 Date: Wed, 7 Dec 2016 13:28:24 +0000 From: Matt Fleming To: Sai Praneeth Prakhya Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, jlee@suse.com, bp@alien8.de, ricardo.neri@intel.com, ard.biesheuvel@linaro.org, ravi.v.shankar@intel.com, fenghua.yu@intel.com Subject: Re: [PATCH 1/4] efi: Make EFI_MEMORY_ATTRIBUTES_TABLE initialization common across all architectures Message-ID: <20161207132824.GA17720@codeblueprint.co.uk> References: <1481051763-8705-1-git-send-email-sai.praneeth.prakhya@intel.com> <1481051763-8705-2-git-send-email-sai.praneeth.prakhya@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1481051763-8705-2-git-send-email-sai.praneeth.prakhya@intel.com> User-Agent: Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1294 Lines: 29 On Tue, 06 Dec, at 11:16:00AM, Sai Praneeth Prakhya wrote: > From: Sai Praneeth > > Since EFI_PROPERTIES_TABLE and EFI_MEMORY_ATTRIBUTES_TABLE deal with > updating memory region attributes, it makes sense to call > EFI_MEMORY_ATTRIBUTES_TABLE initialization function from the same place > as EFI_PROPERTIES_TABLE. This also moves the EFI_MEMORY_ATTRIBUTES_TABLE > initialization code to a more generic efi initialization path rather > than ARM specific efi initialization. This is important because > EFI_MEMORY_ATTRIBUTES_TABLE will be supported by x86 as well. > > Signed-off-by: Sai Praneeth Prakhya > Cc: Lee, Chun-Yi > Cc: Borislav Petkov > Cc: Ricardo Neri > Cc: Matt Fleming > Cc: Ard Biesheuvel > Cc: Ravi Shankar > Cc: Fenghua Yu > --- > drivers/firmware/efi/arm-init.c | 1 - > drivers/firmware/efi/efi.c | 2 ++ > 2 files changed, 2 insertions(+), 1 deletion(-) You should have applied Joey's Reviewed-by tag when sending out this version so that it doesn't get lost. It's not a big deal, just something to watch out for with future submissions.