Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752918AbcLGN4v (ORCPT ); Wed, 7 Dec 2016 08:56:51 -0500 Received: from mail-wj0-f182.google.com ([209.85.210.182]:33551 "EHLO mail-wj0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752475AbcLGN4t (ORCPT ); Wed, 7 Dec 2016 08:56:49 -0500 Date: Wed, 7 Dec 2016 13:56:46 +0000 From: Matt Fleming To: Sai Praneeth Prakhya Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, jlee@suse.com, bp@alien8.de, ricardo.neri@intel.com, ard.biesheuvel@linaro.org, ravi.v.shankar@intel.com, fenghua.yu@intel.com Subject: Re: [PATCH 0/4] UEFI: EFI_MEMORY_ATTRIBUTES_TABLE support for x86 Message-ID: <20161207135646.GC17720@codeblueprint.co.uk> References: <1481051763-8705-1-git-send-email-sai.praneeth.prakhya@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1481051763-8705-1-git-send-email-sai.praneeth.prakhya@intel.com> User-Agent: Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2098 Lines: 48 On Tue, 06 Dec, at 11:15:59AM, Sai Praneeth Prakhya wrote: > From: Sai Praneeth > > UEFI v2.6 introduces EFI_MEMORY_ATTRIBUTES_TABLE which describes memory > protections that may be applied to EFI Runtime code and data regions by > kernel. This helps kernel to map efi runtime regions more strictly and > hence allowing only appropriate accesses to these regions. Please refer > to "EFI_MEMORY_ATTRIBUTES_TABLE" in section 4.6 of UEFI specification > v2.6 for more information on this table. > > This patch set relies on commit a604af075a32 ("efi: Add support for the > EFI_MEMORY_ATTRIBUTES_TABLE config table"), commit 10f0d2f57705 ("efi: > Implement generic support for the Memory Attributes table") and hence > implements support for only x86. > > Since the above commits have already implemented early discovery and > validation of table, the following patches implement a call back > function for x86 which is called only when EFI_MEMORY_ATTRIBUTES_TABLE > is detected. > > Patch #1 makes the efi_memory_attributes table detection code generic > across all architectures > > Patch #2 adds EFI_MEM_ATTR bit to keep track of this feature > > Patch #3 Implements call back function that does stricter mappings based > on this table > > Patch #4 Skip parsing of EFI_PROPERTIES_TABLE if EFI_MEMORY_ATTRIBUTES_TABLE > is detected > > Sai Praneeth (4): > efi: Make EFI_MEMORY_ATTRIBUTES_TABLE initialization common across all > architectures > efi: Introduce EFI_MEM_ATTR bit and set it from memory attributes > table > x86/efi: Add support for EFI_MEMORY_ATTRIBUTES_TABLE > efi: Skip parsing of EFI_PROPERTIES_TABLE if > EFI_MEMORY_ATTRIBUTES_TABLE is detected > > arch/x86/platform/efi/efi_64.c | 64 ++++++++++++++++++++++++++++++++++------- > drivers/firmware/efi/arm-init.c | 1 - > drivers/firmware/efi/efi.c | 13 +++++++++ > drivers/firmware/efi/memattr.c | 6 +++- > include/linux/efi.h | 1 + > 5 files changed, 73 insertions(+), 12 deletions(-) Thanks Sai, I've queued this up for v4.11.