Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932607AbcLGPXt (ORCPT ); Wed, 7 Dec 2016 10:23:49 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:32836 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932196AbcLGPXr (ORCPT ); Wed, 7 Dec 2016 10:23:47 -0500 Subject: Re: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space To: Oleg Drokin References: <20161202173332.5100-1-lambert.quentin@gmail.com> <306D1D4D-A949-44F6-BAFE-44F08F609D9B@intel.com> <81821426-c32c-c45a-e9a3-82f9818fc986@gmail.com> Cc: Andreas Dilger , James Simmons , Greg Kroah-Hartman , lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org From: Quentin Lambert Message-ID: <33d23121-e5ca-0e14-bfbb-632f883e0948@gmail.com> Date: Wed, 7 Dec 2016 16:20:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.0 MIME-Version: 1.0 In-Reply-To: <81821426-c32c-c45a-e9a3-82f9818fc986@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 614 Lines: 21 Hi all, I am looking at the drivers/staging/lustre/lustre/llite/dir.c: 1469 /* Call mdc_iocontrol */ 1470 rc = obd_iocontrol(LL_IOC_FID2MDTIDX, exp, sizeof(fid), &fid, 1471 &index); 1472 if (rc) and sparse says: drivers/staging/lustre/lustre/llite/dir.c:1471:37: warning: incorrect type in argument 5 (different address spaces) I was wondering if there was any value to add a cast to fix the warning? And I guess this solution would also apply in my original patch to drivers/staging/lustre/lnet/lnet/lib-socket.c Quentin